cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hugo Trippaers" <htrippa...@schubergphilis.com>
Subject Re: Review Request 18066: Fixing troubling issues on contrail plugin found by FindBugs
Date Fri, 14 Feb 2014 08:54:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18066/#review34463
-----------------------------------------------------------



plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java
<https://reviews.apache.org/r/18066/#comment64578>

    Why is this made transient?



plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java
<https://reviews.apache.org/r/18066/#comment64579>

    Why should this be set to a random UUID at this point?



plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java
<https://reviews.apache.org/r/18066/#comment64580>

    Why don't you use the UUID.fromString to validate the UUID?



plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java
<https://reviews.apache.org/r/18066/#comment64581>

    In the original code this would not be executed, why execute it now?


- Hugo Trippaers


On Feb. 13, 2014, 11:32 a.m., Wilder Rodrigues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18066/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2014, 11:32 a.m.)
> 
> 
> Review request for cloudstack, daan Hoogland and Hugo Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Fixing troubling issues on contrail plugin related to dereference nullpoint; adding unit
tests to cover changes on the compare method on the VirtualNetworkModel
> 
> 
> Diffs
> -----
> 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java
b25de48 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java
1b048ed 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java
0ce22ad 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java
4d0218c 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java
b0505b1 
>   plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/model/VirtualMachineModelTest.java
f85beb6 
>   plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/model/VirtualNetworkModelTest.java
b1b5ae1 
> 
> Diff: https://reviews.apache.org/r/18066/diff/
> 
> 
> Testing
> -------
> 
> Build successful + 3 unit tests added in order to cover compare methods cases.
> 
> 
> Thanks,
> 
> Wilder Rodrigues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message