cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gaurav Aradhye" <gaurav.arad...@clogeny.com>
Subject Re: Review Request 18016: CLOUDSTACK-5626: Simplifying VM Migrate code
Date Fri, 14 Feb 2014 07:54:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18016/
-----------------------------------------------------------

(Updated Feb. 14, 2014, 1:24 p.m.)


Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.


Changes
-------

Review changes as suggested.


Bugs: CLOUDSTACK-5626
    https://issues.apache.org/jira/browse/CLOUDSTACK-5626


Repository: cloudstack-git


Description
-------

Removing different ways of obtaining suitable hosts. Used built in API "findHostsForMigration"
and skipped the test if suitable host is not found instead of throwing assertion error.
Removed unnecessary common function.


Diffs (updated)
-----

  test/integration/component/test_cpu_domain_limits.py c427e4f 
  test/integration/component/test_cpu_limits.py bdf2869 
  test/integration/component/test_cpu_project_limits.py a8a1b3c 
  test/integration/component/test_memory_limits.py 7921e4b 
  test/integration/component/test_mm_domain_limits.py 68660c1 
  test/integration/component/test_mm_project_limits.py c314011 
  test/integration/component/test_vpc_vm_life_cycle.py 01373ac 
  tools/marvin/marvin/codes.py 74fb05d 
  tools/marvin/marvin/integration/lib/common.py e202391 

Diff: https://reviews.apache.org/r/18016/diff/


Testing
-------

Yes.


Thanks,

Gaurav Aradhye


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message