cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alena Prokharchyk" <alena.prokharc...@citrix.com>
Subject Re: Review Request 17872: remove nic in network with dhcp
Date Thu, 13 Feb 2014 18:55:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17872/#review34397
-----------------------------------------------------------

Ship it!


Ship It!

- Alena Prokharchyk


On Feb. 8, 2014, 2:49 p.m., daan Hoogland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17872/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2014, 2:49 p.m.)
> 
> 
> Review request for cloudstack and Alena Prokharchyk.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> remove nic in network with dhcp plus tests to make sure it is not called for domainrouter
or when dhcp not supported
> 
> 
> Diffs
> -----
> 
>   engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
ce40762 
>   engine/orchestration/test/org/apache/cloudstack/engine/orchestration/NetworkOrchestratorTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17872/diff/
> 
> 
> Testing
> -------
> 
> unit tests added. no extensive integration testing done.
> 
> 
> Thanks,
> 
> daan Hoogland
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message