cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Santhosh Edukulla" <santhosh.eduku...@citrix.com>
Subject Re: Review Request 17702: CLOUDSTACK-2232: Adding automation test cases for Persistent Networks feature
Date Wed, 12 Feb 2014 17:23:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17702/#review34292
-----------------------------------------------------------



test/integration/component/test_persistent_networks.py
<https://reviews.apache.org/r/17702/#comment64320>

    Not clear with break here, what to do post break. In the tests, we are not checking these
cases of return?



test/integration/component/test_persistent_networks.py
<https://reviews.apache.org/r/17702/#comment64323>

    This step is not visible in test code, is it like enable\disable flag to create network?
or offeringid we are passing?



test/integration/component/test_persistent_networks.py
<https://reviews.apache.org/r/17702/#comment64321>

    Please empty the clean up list after every case in tear down post after cleanup



test/integration/component/test_persistent_networks.py
<https://reviews.apache.org/r/17702/#comment64322>

    We dont check the return of function here. 



test/integration/component/test_persistent_networks.py
<https://reviews.apache.org/r/17702/#comment64324>

    This step is not visible in steps though.



test/integration/component/test_persistent_networks.py
<https://reviews.apache.org/r/17702/#comment64325>

    Lot of places this code is repeated, may be we can use a small utility function to keep
it simple.



test/integration/component/test_persistent_networks.py
<https://reviews.apache.org/r/17702/#comment64326>

    why this code is used two times before and after router list?



test/integration/component/test_persistent_networks.py
<https://reviews.apache.org/r/17702/#comment64327>

    If it fails here, account wont be deleted? Dont we add to clean up in case if it fails
and during teardown account gets cleaned up? 



test/integration/component/test_persistent_networks.py
<https://reviews.apache.org/r/17702/#comment64328>

    Is waiting required post disable\lock? or after Account.list?



tools/marvin/marvin/integration/lib/base.py
<https://reviews.apache.org/r/17702/#comment64319>

    May be we can control the behavior or true\false using one function only. We don't need
both disable and lock i believe


- Santhosh Edukulla


On Feb. 4, 2014, 12:08 p.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17702/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2014, 12:08 p.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-2232
>     https://issues.apache.org/jira/browse/CLOUDSTACK-2232
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Adding automation test cases for Persistent Networks feature.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_persistent_networks.py f61ccaa 
>   tools/marvin/marvin/config/config.cfg 5849fe8 
>   tools/marvin/marvin/integration/lib/base.py 409530c 
> 
> Diff: https://reviews.apache.org/r/17702/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message