cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Devdeep Singh" <devdeep.si...@citrix.com>
Subject Re: Review Request 17842: fixed vmsync for hyperv
Date Mon, 10 Feb 2014 05:56:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17842/#review34046
-----------------------------------------------------------



plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs
<https://reviews.apache.org/r/17842/#comment64013>

    There is already a WmiCallsV2::EnabledState class defined. Please use that.



plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
<https://reviews.apache.org/r/17842/#comment64015>

    Hyperv agent should map the hyper-v state to cloudstack state and return an appropriate
state in the answer. Lookat WmiCallsV2::EnabledState.ToCloudStackState


- Devdeep Singh


On Feb. 7, 2014, 11:22 a.m., Anshul Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17842/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2014, 11:22 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
> 
> 
> Bugs: CLOUDSTACK-6054
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6054
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> fixed vmsync for hyperv. This fix adds an api call which return the hostvmstatereport
and made appropriate changes to HypervDirectConnectResource.java 
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/CloudStackTypes.cs
9637994 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs
a132606 
>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/IWmiCallsV2.cs 5f814c5

>   plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs f5a04dc

>   plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
a4dca6a 
> 
> Diff: https://reviews.apache.org/r/17842/diff/
> 
> 
> Testing
> -------
> 
> Performed basic vm operations externally and verifying their state got updated correctly
in cloudstack 
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message