cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "daan Hoogland" <daan.hoogl...@gmail.com>
Subject Review Request 17872: remove nic in network with dhcp
Date Sat, 08 Feb 2014 14:49:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17872/
-----------------------------------------------------------

Review request for cloudstack and Alena Prokharchyk.


Repository: cloudstack-git


Description
-------

remove nic in network with dhcp plus tests to make sure it is not called for domainrouter
or when dhcp not supported


Diffs
-----

  engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
ce40762 
  engine/orchestration/test/org/apache/cloudstack/engine/orchestration/NetworkOrchestratorTest.java
PRE-CREATION 

Diff: https://reviews.apache.org/r/17872/diff/


Testing
-------

unit tests added. no extensive integration testing done.


Thanks,

daan Hoogland


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message