cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashutosh Kelkar" <ashut...@clogeny.com>
Subject Review Request 17847: CLOUDSTACK-5978: Changes in get_template function to make it independent of ostype passed through test case
Date Fri, 07 Feb 2014 13:59:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17847/
-----------------------------------------------------------

Review request for cloudstack and Girish Shilamkar.


Bugs: CLOUDSTACK-5978
    https://issues.apache.org/jira/browse/CLOUDSTACK-5978


Repository: cloudstack-git


Description
-------

Some test cases are failing because the ostype passed to the get_template function is different
in each test case and it fails whenever it does not match with the ostype of template in the
CS setup. Changed get_template function so that ostype id does not have any effect on the
returning data (It will always return the feature, built in template in the given zone which
is in READY state). This way we eliminate the dependency between the test case and the CS
setup.

This is the first set of change in marvin library. In next step, we can remove the hard coded
ostype from all the test cases. For now, this is sufficient to save test cases from failing
due to hard coded value.


Diffs
-----

  tools/marvin/marvin/integration/lib/common.py 550de1a 

Diff: https://reviews.apache.org/r/17847/diff/


Testing
-------

Yes.


Thanks,

Ashutosh Kelkar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message