cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gaurav Aradhye" <gaurav.arad...@clogeny.com>
Subject Review Request 17841: CLOUDSTACK-5959: Fixed cascading failures in portable IP test cases
Date Fri, 07 Feb 2014 10:56:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17841/
-----------------------------------------------------------

Review request for cloudstack and Girish Shilamkar.


Bugs: CLOUDSTACK-5959
    https://issues.apache.org/jira/browse/CLOUDSTACK-5959


Repository: cloudstack-git


Description
-------

Failure in firewall creation is leading to incomplete cleanup and eventually cascading failure
of the test cases.
Made changes so that even in case of failure in one test case, other test cases are not affected
and cleanup is performed gracefully.

Also did
1) Code cleanup
2) Modifying imports
3) Adding FS and test plan links
4) Refactoring code


Diffs
-----

  test/integration/component/test_portable_ip.py d397ec4 
  tools/marvin/marvin/integration/lib/common.py 550de1a 

Diff: https://reviews.apache.org/r/17841/diff/


Testing
-------

Tested on VMware


Thanks,

Gaurav Aradhye


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message