cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Saksham Srivastava" <saksham.srivast...@citrix.com>
Subject Re: Review Request 17736: CLOUDSTACK-5999: Virtual Router does not start if Guest VM is rebooted from CloudStack
Date Fri, 07 Feb 2014 09:25:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17736/#review33921
-----------------------------------------------------------



server/src/com/cloud/vm/UserVmManagerImpl.java
<https://reviews.apache.org/r/17736/#comment63715>

    Thanks John for the comments.
    Created single list and now using new utility to grab the domain router for the network.


- Saksham Srivastava


On Feb. 5, 2014, 8:46 a.m., Saksham Srivastava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17736/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2014, 8:46 a.m.)
> 
> 
> Review request for cloudstack and Murali Reddy.
> 
> 
> Bugs: CLOUDSTACK-5999
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5999
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> When a guest is rebooted from CloudStack, if the virtual router managing the guest network
of that guest is down, CloudStack will not start the virtual router.
> However the router is started in case the guest vm is stopped and then started.
> To mantain similarity between the 2 process it is necessary to start the VR in case it
is not running.
> The fix will address the same.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 81be19f 
> 
> Diff: https://reviews.apache.org/r/17736/diff/
> 
> 
> Testing
> -------
> 
> Testing:
> 1) vm in a single guest network :
>                vm Reboot : If the VR is stopped: VR is first started and then the VM
reboots.
>                vm Reboot : If the VR is running, VM reboots as it used to.
> vm Stop/Start continue to work the same.
> 
> 2)  vm having nics in multi networks :
>                vm Reboot : If VR in any/all network is stopped: VRs are first started
and then the VM reboots.
>                vm Reboot : If the VRs are running, VM reboots as it used to.
> vm Stop/Start continue to work the same.
> 
> 3) vpc :
>                Tested the above scenarios for vpc also, works fine.
> 
> Patch applies cleanly.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message