cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "suresh sadhu" <mailtosa...@gmail.com>
Subject Review Request 17789: method to handle default template changes
Date Thu, 06 Feb 2014 14:06:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17789/
-----------------------------------------------------------

Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri.


Bugs: cloudstack-6042
    https://issues.apache.org/jira/browse/cloudstack-6042


Repository: cloudstack-git


Description
-------

Right now default template for xen changed  and test scripts are still point to old template
,due to this deployvm and other scripts are failing and its hard coded in  each script.

So I wrote a method to  return  built-in OS name dynamically.

but here we need to add one line of code in each script

 
another  solution is :

we have get_template method and  again this is depend on hardcoded parameter  type ostype.this
is generic method .  ,if modify exiting logic little bit(it won't be generic and specific
to built-in template)then no need to touch other scripts. 


Please review and share you input 


Diffs
-----

  tools/marvin/marvin/integration/lib/common.py 550de1a 

Diff: https://reviews.apache.org/r/17789/diff/


Testing
-------

yes


Thanks,

suresh sadhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message