cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Antonio Fornie" <antonio.for...@gmail.com>
Subject Re: Review Request 17638: Rest client moved to utils. Nvp extended.
Date Thu, 06 Feb 2014 12:53:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17638/
-----------------------------------------------------------

(Updated Feb. 6, 2014, 12:53 p.m.)


Review request for cloudstack, daan Hoogland and Hugo Trippaers.


Changes
-------

Corrections and fixes to remove any mention to Nvp. Also some explanations in the Headers.


Repository: cloudstack-git


Description
-------

Rest client moved to utils in a generic way so it can be reused (from opendaylight, for example).
Incremented integration tests. Also include cobertura and it-cobertura. Nvp extended with
a few methods missing.


Diffs (updated)
-----

  plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/AccessConfiguration.java
487f14b 
  plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/Acl.java 976177f 
  plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/BaseNiciraEntity.java PRE-CREATION

  plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/BaseNiciraNamedEntity.java
PRE-CREATION 
  plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/LogicalRouter.java PRE-CREATION

  plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/LogicalRouterConfig.java
b6eaa8f 
  plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/LogicalRouterPort.java
8ffe054 
  plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/LogicalSwitch.java 2379354

  plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/LogicalSwitchPort.java
3565fbe 
  plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java 83d0075

  plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/SingleDefaultRouteImplicitRoutingConfig.java
PRE-CREATION 
  plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/SingleDefaultRouteImplictRoutingConfig.java
0533579 
  plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/VifAttachment.java 87765be

  plugins/network-elements/nicira-nvp/src/com/cloud/network/resource/NiciraNvpResource.java
c228b08 
  plugins/network-elements/nicira-nvp/test/com/cloud/network/element/NiciraNvpElementTest.java
822c8c7 
  plugins/network-elements/nicira-nvp/test/com/cloud/network/guru/NiciraNvpGuestNetworkGuruTest.java
db8637c 
  plugins/network-elements/nicira-nvp/test/com/cloud/network/nicira/NatRuleTest.java 84b28fb

  plugins/network-elements/nicira-nvp/test/com/cloud/network/nicira/NiciraNvpApiIT.java 7f8f471

  plugins/network-elements/nicira-nvp/test/com/cloud/network/nicira/NiciraNvpApiTest.java
13d970c 
  plugins/network-elements/nicira-nvp/test/com/cloud/network/nicira/NiciraTagTest.java 58dcedc

  plugins/network-elements/nicira-nvp/test/com/cloud/network/resource/NiciraNvpResourceTest.java
2717c31 
  pom.xml 1d2304f 
  utils/pom.xml f63d7c4 
  utils/src/com/cloud/utils/rest/BasicEncodedRESTValidationStrategy.java PRE-CREATION 
  utils/src/com/cloud/utils/rest/CloudstackRESTException.java PRE-CREATION 
  utils/src/com/cloud/utils/rest/RESTServiceConnector.java PRE-CREATION 
  utils/src/com/cloud/utils/rest/RESTValidationStrategy.java PRE-CREATION 
  utils/test/com/cloud/utils/rest/RESTServiceConnectorTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/17638/diff/


Testing
-------

mvn full build plus unit and integration tests


Thanks,

Antonio Fornie


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message