cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "daan Hoogland" <daan.hoogl...@gmail.com>
Subject Re: Review Request 16523: Unit tests for Juniper contrail VM Interface Model and Instance Ip Model class.
Date Thu, 06 Feb 2014 09:41:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16523/#review33783
-----------------------------------------------------------


I don't think it will pass checkstyle yet, because of the
import <this or that>.*;

it is not permitted by our build. (and I don't like the typesafety implications of it.)

- daan Hoogland


On Feb. 5, 2014, 11:23 p.m., Sachchidanand Vaidya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16523/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2014, 11:23 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Added unit tests for Juniper contrail VM Interface Model and Instance Ip Model class.
> 
> 
> Diffs
> -----
> 
>   plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/InstanceIpModelTest.java
PRE-CREATION 
>   plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VMInterfaceModelTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16523/diff/
> 
> 
> Testing
> -------
> 
> All Juniper contrail plugin unit tests pass without any error.
> 
> 
> Thanks,
> 
> Sachchidanand Vaidya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message