cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "daan Hoogland" <daan.hoogl...@gmail.com>
Subject Re: Review Request 17748: Solve fixBugs finding
Date Thu, 06 Feb 2014 09:33:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17748/#review33782
-----------------------------------------------------------

Ship it!


cecb216caa22541d243369e76ef80b4f2225b728

- daan Hoogland


On Feb. 5, 2014, 5:45 p.m., Ian Southam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17748/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2014, 5:45 p.m.)
> 
> 
> Review request for cloudstack and daan Hoogland.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> fixBugs raised this as a scariest category bug.
> 
> Equals is breaking its contract by comparing (potentially) unequal objects.
> 
> (In the end, The helper class is referenced in spring and being used) 
> 
> 
> Diffs
> -----
> 
>   engine/storage/src/org/apache/cloudstack/storage/image/format/ImageFormatHelper.java
9523d24 
> 
> Diff: https://reviews.apache.org/r/17748/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ian Southam
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message