cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Santhosh Edukulla" <santhosh.eduku...@citrix.com>
Subject Review Request 17658: Added Few changes for CLOUDSTACK-5980
Date Mon, 03 Feb 2014 13:05:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17658/
-----------------------------------------------------------

Review request for cloudstack and Girish Shilamkar.


Bugs: CLOUDSTACK-5980
    https://issues.apache.org/jira/browse/CLOUDSTACK-5980


Repository: cloudstack-git


Description
-------

1. Added a timeout flag to execute.. command under sshClient
2. Added a break in finally for createConnection,when command is successful, earlier it was
running despite that
3. Added load.. call  when key_pair files are passed.
4. Cleaned up few things under cloudstackConnection.

Please apply it on marvin branch.


Diffs
-----

  tools/marvin/marvin/cloudstackConnection.py 8413ac0 
  tools/marvin/marvin/sshClient.py 09dc6f3 

Diff: https://reviews.apache.org/r/17658/diff/


Testing
-------

Ran pep8 and more tests as part of marvin branch will be run.


Thanks,

Santhosh Edukulla


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message