cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Antonio Fornie" <antonio.for...@gmail.com>
Subject Re: Review Request 17576: Detect & log unknown parameters for CS API and refactoring
Date Mon, 03 Feb 2014 10:18:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17576/
-----------------------------------------------------------

(Updated Feb. 3, 2014, 10:17 a.m.)


Review request for cloudstack, daan Hoogland and Hugo Trippaers.


Changes
-------

Improved some code and design (refactored a few more things) and also added several more tests
for the new code.


Repository: cloudstack-git


Description
-------

Detect & log unknown parameters for CS API and refactoring. There are plenty of changes
for just refactoring purpose, but they are all related, most of them interdependant


Diffs (updated)
-----

  api/src/org/apache/cloudstack/api/ApiConstants.java d500303 
  api/src/org/apache/cloudstack/api/BaseCmd.java 4229ec9 
  api/src/org/apache/cloudstack/api/BaseListCmd.java c1a4b4c 
  api/src/org/apache/cloudstack/api/command/user/autoscale/CreateAutoScaleVmProfileCmd.java
bee1b22 
  build/replace.properties 265f335 
  server/src/com/cloud/api/ApiAsyncJobDispatcher.java 71ac616 
  server/src/com/cloud/api/ApiDispatcher.java 55ef53a 
  server/src/com/cloud/api/ApiServer.java d715db6 
  server/src/com/cloud/api/ApiServlet.java 46f7eba 
  server/src/com/cloud/api/ParameterHandler.java PRE-CREATION 
  server/src/com/cloud/api/dispatch/CommandCreationWorker.java PRE-CREATION 
  server/src/com/cloud/api/dispatch/DispatchChainFactory.java PRE-CREATION 
  server/src/com/cloud/api/dispatch/DispatchWorker.java PRE-CREATION 
  server/src/com/cloud/api/dispatch/ParamGenericValidationWorker.java PRE-CREATION 
  server/src/com/cloud/api/dispatch/ParamProcessWorker.java PRE-CREATION 
  server/src/com/cloud/api/dispatch/ParamSemanticValidationWorker.java PRE-CREATION 
  server/src/com/cloud/network/as/AutoScaleManagerImpl.java a2cc32e 
  server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java bf2516a 
  server/src/com/cloud/storage/snapshot/SnapshotSchedulerImpl.java 3159059 
  server/src/com/cloud/vm/UserVmManagerImpl.java 82b9bfb 
  server/test/com/cloud/api/ApiDispatcherTest.java 7314a57 
  server/test/com/cloud/api/dispatch/CommandCreationWorkerTest.java PRE-CREATION 
  server/test/com/cloud/api/dispatch/DispatchChainFactoryTest.java PRE-CREATION 
  server/test/com/cloud/api/dispatch/ParamGenericValidationWorkerTest.java PRE-CREATION 
  server/test/com/cloud/api/dispatch/ParamProcessWorkerTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/17576/diff/


Testing
-------

mvn full build and manual test of functionalities


Thanks,

Antonio Fornie


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message