cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Antonio Fornie" <antonio.for...@gmail.com>
Subject Re: Review Request 17638: Rest client moved to utils. Nvp extended.
Date Mon, 03 Feb 2014 08:48:45 GMT


> On Feb. 2, 2014, 11:21 a.m., David Nalley wrote:
> > pom.xml, line 181
> > <https://reviews.apache.org/r/17638/diff/1/?file=462740#file462740line181>
> >
> >     Hardcoded repo url?? Please no :)

Thanks David. I could mode it to my local settings, but then the build will fail for anybody
who pulls the changes, because cobertura-it-maven-plugin as far as I know it's only found
at http://cobertura-it-maven-plugin.googlecode.com/... so this would brake everybody's build
until they find the plugin repo and add it to their local settings too. Still your comment
is valid, because many people will prefer to use only their repos, but how do I let everybody
know what to do in advance in order not to brake their builds? Thanks again. Cheers


- Antonio


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17638/#review33396
-----------------------------------------------------------


On Feb. 2, 2014, 7:47 a.m., Antonio Fornie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17638/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2014, 7:47 a.m.)
> 
> 
> Review request for cloudstack, daan Hoogland and Hugo Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Rest client moved to utils in a generic way so it can be reused (from opendaylight, for
example). Incremented integration tests. Also include cobertura and it-cobertura. Nvp extended
with a few methods missing.
> 
> 
> Diffs
> -----
> 
>   plugins/network-elements/nicira-nvp/pom.xml a4b4c49 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/AccessConfiguration.java
74fe19d 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/Acl.java 3a9b387 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/BaseNiciraEntity.java
PRE-CREATION 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/BaseNiciraNamedEntity.java
PRE-CREATION 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/LogicalRouter.java
PRE-CREATION 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/LogicalRouterConfig.java
5c99e15 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/LogicalRouterPort.java
ed1b8da 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/LogicalSwitch.java
c2d75a7 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/LogicalSwitchPort.java
da58c78 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java
92c23eb 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/SingleDefaultRouteImplicitRoutingConfig.java
PRE-CREATION 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/SingleDefaultRouteImplictRoutingConfig.java
d386e70 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/VifAttachment.java
7b37ac1 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/resource/NiciraNvpResource.java
8c99a81 
>   plugins/network-elements/nicira-nvp/test/com/cloud/network/element/NiciraNvpElementTest.java
436c86c 
>   plugins/network-elements/nicira-nvp/test/com/cloud/network/guru/NiciraNvpGuestNetworkGuruTest.java
3e303b8 
>   plugins/network-elements/nicira-nvp/test/com/cloud/network/nicira/NatRuleTest.java
1a63527 
>   plugins/network-elements/nicira-nvp/test/com/cloud/network/nicira/NiciraNvpApiIT.java
c541d87 
>   plugins/network-elements/nicira-nvp/test/com/cloud/network/nicira/NiciraNvpApiTest.java
2e4cfaf 
>   plugins/network-elements/nicira-nvp/test/com/cloud/network/nicira/NiciraTagTest.java
7512803 
>   plugins/network-elements/nicira-nvp/test/com/cloud/network/resource/NiciraNvpResourceTest.java
ad01218 
>   pom.xml 85cfb89 
>   utils/pom.xml f63d7c4 
>   utils/src/com/cloud/utils/rest/BasicEncodedRESTValidationStrategy.java PRE-CREATION

>   utils/src/com/cloud/utils/rest/CloudstackRESTException.java PRE-CREATION 
>   utils/src/com/cloud/utils/rest/RESTServiceConnector.java PRE-CREATION 
>   utils/src/com/cloud/utils/rest/RESTValidationStrategy.java PRE-CREATION 
>   utils/test/com/cloud/utils/rest/RESTServiceConnectorTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17638/diff/
> 
> 
> Testing
> -------
> 
> mvn full build plus unit and integration tests
> 
> 
> Thanks,
> 
> Antonio Fornie
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message