cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Prasanna Santhanam <...@apache.org>
Subject Re: Add reviewer to Review requests (was: ReviewBoard)
Date Sun, 02 Feb 2014 16:18:36 GMT
the best way is to find the person who changed the file you changed
most and include them as reviewer. `git blame` FTW.

On Sun, Feb 02, 2014 at 04:29:39PM +0100, Daan Hoogland wrote:
> but I would give preference to whoever you discussed a thingy with.
> 
> On Sun, Feb 2, 2014 at 4:27 PM, Daan Hoogland <daan.hoogland@gmail.com> wrote:
> > It should be on the wiki :
> > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Current+Maintainers+Per+Component
> >
> > On Sun, Feb 2, 2014 at 4:19 PM, Laszlo Hornyak <laszlo.hornyak@gmail.com>
wrote:
> >> Hi Daan,
> >>
> >> I would start doing so right now, but I have never heard of a list of
> >> component maintainers and google didn't find one for me either. Ideally,
> >> such list should be here: http://cloudstack.apache.org/developers.html or
> >> it should be at least linked from this page.
> >>
> >> Thank you,
> >> Laszlo
> >>
> >>
> >> On Sun, Feb 2, 2014 at 11:26 AM, Daan Hoogland <daan.hoogland@gmail.com>wrote:
> >>
> >>> LS,
> >>>
> >>> I would like to see contributers add reviewers to their submissions. I
> >>> noticed quite soe old review requests that don't have anyone's
> >>> attention. There are component 'owners' for everything and I have easy
> >>> speach as I am not listed as contact for any component but I wouldn't
> >>> mind being assinged and then calling in who I considder the expert on
> >>> a subject. It will prevent these long standing review requests in my
> >>> opinion.
> >>>
> >>> thoughts, counters, rants?
> >>>
> >>> Daan
> >>>
> >>> On Sun, Feb 2, 2014 at 10:38 AM, David Nalley <david@gnsa.us> wrote:
> >>> > I have not. Yesterday RB went down for some period of time, though
> >>> > AFAIK, infra restored it.
> >>> >
> >>> > --David
> >>> >
> >>> > On Sat, Feb 1, 2014 at 4:11 PM, Daan Hoogland <daan.hoogland@gmail.com>
> >>> wrote:
> >>> >> H David,
> >>> >>
> >>> >> have you started on this yet?
> >>> >> I can't reach the review board at the moment.
> >>> >>
> >>> >> On Mon, Jan 27, 2014 at 8:59 PM, David Nalley <david@gnsa.us>
wrote:
> >>> >>> Hi folks:
> >>> >>>
> >>> >>> ReviewBoard is pretty bloated. There are currently 93 reviews
that are
> >>> open.
> >>> >>>
> >>> >>> Some of those haven't been updated in 7 months old.
> >>> >>>
> >>> >>> Unless someone objects (and promptly begins reviewing and applying
> >>> >>> patches) I will close any patch that hasn't been updated in
2 months.
> >>> >>>
> >>> >>> Please take a few minutes to go look through ReviewBoard and
update
> >>> >>> things as appropriate.
> >>> >>>
> >>> >>> --David
> >>>
> >>
> >>
> >>
> >> --
> >>
> >> EOF

-- 
Prasanna.,

------------------------
Powered by BigRock.com


Mime
View raw message