Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Received-SPF: pass (nike.apache.org: domain of vaidyasd@juniper.net designates
 213.199.154.253 as permitted sender)
Received-SPF: pass (mail139-db9: domain of juniper.net designates
 157.56.240.101 as permitted sender) client-ip=157.56.240.101;
 envelope-from=vaidyasd@juniper.net;
 helo=BL2PRD0510HT003.namprd05.prod.outlook.com ;.outlook.com ;
From: Sachchidanand Vaidya <vaidyasd@juniper.net>
To: "dev@cloudstack.apache.org" <dev@cloudstack.apache.org>, Sheng Yang
	<sheng@yasker.org>
Subject: Re: Review Request 16258: Add new physical network isolationMethod
 (L3VPN) for Juniper Contrail plugin.
Thread-Topic: Review Request 16258: Add new physical network isolationMethod
 (L3VPN) for Juniper Contrail plugin.
Thread-Index: AQHO+E3kLUoX8s5JikO7O2nyydj8U5qCVRiAgAKYpwD//39vgA==
Date: Tue, 14 Jan 2014 21:45:36 +0000
Message-ID: <CEFAEFC8.55D13%vaidyasd@juniper.net>
References: <20140113054649.20235.96975@reviews.apache.org>
 <20140114212542.7700.834@reviews.apache.org>
In-Reply-To: <20140114212542.7700.834@reviews.apache.org>
Accept-Language: en-US
Content-Language: en-US
user-agent: Microsoft-MacOutlook/14.3.9.131030
Content-Type: text/plain; charset="us-ascii"
Content-ID: <0AC385BDBEE3D5449CBED096C692B1D8@namprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Hi Sheng,
   I have updated the review with changes based off latest on ACS master.


Thanks & Best Regards,
Sachin

On 1/14/14 1:25 PM, "Sheng Yang" <sheng@yasker.org> wrote:

>
>-----------------------------------------------------------
>This is an automatically generated e-mail. To reply, visit:
>https://reviews.apache.org/r/16258/#review31802
>-----------------------------------------------------------
>
>
>Looks good to me, but cannot applied to the latest MASTER branch(I
>suppose that's the target).
>
>- Sheng Yang
>
>
>On Jan. 13, 2014, 5:46 a.m., Sachchidanand Vaidya wrote:
>>=20
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/16258/
>> -----------------------------------------------------------
>>=20
>> (Updated Jan. 13, 2014, 5:46 a.m.)
>>=20
>>=20
>> Review request for cloudstack.
>>=20
>>=20
>> Repository: cloudstack-git
>>=20
>>=20
>> Description
>> -------
>>=20
>> Add new physical network isolationMethod (L3VPN) for Juniper Contrail
>>network Plugin. ContrailGuru checks for IsolationMethod before designing
>>a VN.=20
>>=20
>>=20
>> Diffs
>> -----
>>=20
>>   api/src/com/cloud/network/PhysicalNetwork.java cfa236d
>>  =20
>>plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/netwo
>>rk/contrail/management/ContrailGuru.java ea52be9
>>  =20
>>plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/netw
>>ork/contrail/management/ManagementServerMock.java c449b8a
>>   ui/scripts/ui-custom/zoneWizard.js 28df193
>>=20
>> Diff: https://reviews.apache.org/r/16258/diff/
>>=20
>>=20
>> Testing
>> -------
>>=20
>> Changes pass unit tests and complete centos63 package build.
>>=20
>>=20
>> Thanks,
>>=20
>> Sachchidanand Vaidya
>>=20
>>
>