Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 733EF10257 for ; Tue, 14 Jan 2014 21:56:34 +0000 (UTC) Received: (qmail 33399 invoked by uid 500); 14 Jan 2014 21:56:33 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 33361 invoked by uid 500); 14 Jan 2014 21:56:33 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 33352 invoked by uid 99); 14 Jan 2014 21:56:33 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Jan 2014 21:56:33 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy includes SPF record at spf.trusted-forwarder.org) Received: from [209.85.214.171] (HELO mail-ob0-f171.google.com) (209.85.214.171) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Jan 2014 21:56:28 +0000 Received: by mail-ob0-f171.google.com with SMTP id wm4so268784obc.2 for ; Tue, 14 Jan 2014 13:56:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=EwLGQ3A0PN3YppWxpq8qgZ/fNax0s19PdYqBV9AstTU=; b=cee1JUin2LUWVQw3ds68ZCtlzf7L+jkurrIZB+Ufg70bQa0GjyrvsFlcqLwROEZaiI SZjbxx5DKhqsaGztywG10fXdb1VNTLdYfTXsHDuvRliTXAMbAZJ/jLSWgYilDX/0oeia EkKfyuSzG8Hc087UIcbLte4JR85MLdWKWyE9djF7fQS3v4h99/zBd5AY0ml9eyZlzMPZ AWmxrJzIzjpopzb2HfsMAgBcnUV7NHwd7eRYxFsb765N3ZXXY1PPDgK9PyHfqk5jhL8a Z2+k5Ly09/HjI26psnUoojCLWRATGS0OyY0DqrK1omE8r7yRtXm9B1NbHUFAfs67O0d9 MdOg== X-Gm-Message-State: ALoCoQkXaUnNUZkmE4hvdAtaKaeaKxoShtV6XdPZZZCAV+JgJvxJRBViwOJ2RA5QfRCFiml/9aI6 X-Received: by 10.182.24.69 with SMTP id s5mr3091995obf.35.1389736567430; Tue, 14 Jan 2014 13:56:07 -0800 (PST) MIME-Version: 1.0 Received: by 10.76.124.1 with HTTP; Tue, 14 Jan 2014 13:55:47 -0800 (PST) In-Reply-To: <20140114215313.32581.5215@reviews.apache.org> References: <20140114015453.20236.25912@reviews.apache.org> <20140114215313.32581.5215@reviews.apache.org> From: David Nalley Date: Tue, 14 Jan 2014 16:55:47 -0500 Message-ID: Subject: Re: Review Request 16841: (ACS4.3): Add new physical network isolationMethod (L3VPN) for Juniper Contrail plugin. To: "dev@cloudstack.apache.org" , Sheng Yang Cc: Sachchidanand Vaidya Content-Type: text/plain; charset=ISO-8859-1 X-Virus-Checked: Checked by ClamAV on apache.org Why are we adding functionality after 4.3 has closed? --David On Tue, Jan 14, 2014 at 4:53 PM, Sheng Yang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16841/#review31810 > ----------------------------------------------------------- > > Ship it! > > > Applied to 4.3 branch. > > Thanks. > > > - Sheng Yang > > > On Jan. 14, 2014, 1:54 a.m., Sachchidanand Vaidya wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/16841/ >> ----------------------------------------------------------- >> >> (Updated Jan. 14, 2014, 1:54 a.m.) >> >> >> Review request for cloudstack. >> >> >> Repository: cloudstack-git >> >> >> Description >> ------- >> >> This diff is on ACS4.3 (Similar to Review Request 16258 for ACS-4.4). >> >> >> Diffs >> ----- >> >> api/src/com/cloud/network/PhysicalNetwork.java 55b18e6 >> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java 6587534 >> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java bbff466 >> ui/scripts/ui-custom/zoneWizard.js 28df193 >> >> Diff: https://reviews.apache.org/r/16841/diff/ >> >> >> Testing >> ------- >> >> Unit testing done. >> >> >> Thanks, >> >> Sachchidanand Vaidya >> >> >