Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 90993104C0 for ; Fri, 24 Jan 2014 12:46:49 +0000 (UTC) Received: (qmail 93970 invoked by uid 500); 24 Jan 2014 12:46:48 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 93587 invoked by uid 500); 24 Jan 2014 12:46:48 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 93578 invoked by uid 99); 24 Jan 2014 12:46:47 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Jan 2014 12:46:47 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,MIME_QP_LONG_LINE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of trippie@gmail.com designates 74.125.83.48 as permitted sender) Received: from [74.125.83.48] (HELO mail-ee0-f48.google.com) (74.125.83.48) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Jan 2014 12:46:38 +0000 Received: by mail-ee0-f48.google.com with SMTP id t10so941300eei.35 for ; Fri, 24 Jan 2014 04:46:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:references:from:content-type:message-id:date:to :content-transfer-encoding:mime-version; bh=vKYZtcaV8enQRAYDW2dygUICCfbQFbiEGYMx4uBovVc=; b=qQ4ONXcEneJSgbputlUF+7UxDqzv5qCSImU25vVp50Osrb9/7GJSdAB8srpMmmcknI pcW6d583lIB/K4FqWpERM2wQwsMTLeELViSBHopOiLeRjNfztBJrxMUL8xpqPDeJ/X+C jlzd/wWhC31wTP/znLMQppEmau+9MWzSS9qvjIZXi5Gjt9bqE+gqzrTj9YGwMzl/Wmen 8BWioy141ht5YXV4LWtF7Lijn7c1+GHRogRW7HHKUyR9Z5EIfD5S1DdW6dKPucIQXJuc H31twkZdHKh1nzEB3K0+0qtVfOC4xMnMacUQKgu+bzrTYg9irDAJj6XDL6aFHRbVW+Tb yxdw== X-Received: by 10.15.49.193 with SMTP id j41mr12304397eew.10.1390567578737; Fri, 24 Jan 2014 04:46:18 -0800 (PST) Received: from [10.47.106.204] ([188.207.100.196]) by mx.google.com with ESMTPSA id v1sm3272790eef.9.2014.01.24.04.46.13 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 24 Jan 2014 04:46:16 -0800 (PST) Subject: Fwd: New Defects reported by Coverity Scan for cloudstack References: <52e25b231a8e9_7fc41117078698eb@209.249.196.67.mail> From: Hugo Trippaers Content-Type: multipart/alternative; boundary=Apple-Mail-4CAE4279-5D87-426E-A4EB-B488F8F3E083 X-Mailer: iPhone Mail (11B554a) Message-Id: Date: Fri, 24 Jan 2014 13:46:10 +0100 To: dev Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (1.0) X-Virus-Checked: Checked by ClamAV on apache.org --Apple-Mail-4CAE4279-5D87-426E-A4EB-B488F8F3E083 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable FYI Sent from my iPhone Begin forwarded message: > From: scan-admin@coverity.com > Date: 24 januari 2014 13:22:59 CET > Subject: New Defects reported by Coverity Scan for cloudstack >=20 >=20 > Hi, >=20 >=20 > Please find the latest report on new defect(s) introduced to cloudstack fo= und with Coverity Scan. >=20 > Defect(s) Reported-by: Coverity Scan > Showing 20 of 52 defect(s) >=20 >=20 > ** CID 1164002: Logically dead code (DEADCODE) > /server/src/com/cloud/api/query/dao/TemplateJoinDaoImpl.java: 388 in com.c= loud.api.query.dao.TemplateJoinDaoImpl.searchByTemplateZonePair(java.lang.Bo= olean, java.lang.String[])() >=20 > ** CID 1164018: Explicit null dereferenced (FORWARD_NULL) > /server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java: 730 in com.c= loud.vm.snapshot.VMSnapshotManagerImpl.deleteAllVMSnapshots(long, com.cloud.= vm.snapshot.VMSnapshot$Type)() >=20 > ** CID 1164020: Explicit null dereferenced (FORWARD_NULL) > /server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java: 478 in com.c= loud.vm.snapshot.VMSnapshotManagerImpl.deleteVMSnapshot(java.lang.Long)() >=20 > ** CID 1164017: Explicit null dereferenced (FORWARD_NULL) > /server/src/com/cloud/storage/VolumeApiServiceImpl.java: 1619 in com.cloud= .storage.VolumeApiServiceImpl.migrateVolume(org.apache.cloudstack.api.comman= d.user.volume.MigrateVolumeCmd)() >=20 > ** CID 1164019: Explicit null dereferenced (FORWARD_NULL) > /server/src/com/cloud/storage/VolumeApiServiceImpl.java: 1721 in com.cloud= .storage.VolumeApiServiceImpl.takeSnapshot(java.lang.Long, java.lang.Long, j= ava.lang.Long, com.cloud.user.Account, boolean)() >=20 > ** CID 1164016: Dereference after null check (FORWARD_NULL) > /server/src/com/cloud/storage/VolumeApiServiceImpl.java: 2033 in com.cloud= .storage.VolumeApiServiceImpl.sendAttachVolumeCommand(com.cloud.vm.UserVmVO,= com.cloud.storage.VolumeVO, java.lang.Long)() >=20 > ** CID 1164013: Dereference after null check (FORWARD_NULL) > /plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/netwo= rk/contrail/model/VirtualNetworkModel.java: 535 in org.apache.cloudstack.net= work.contrail.model.VirtualNetworkModel.compare(org.apache.cloudstack.networ= k.contrail.model.ModelController, org.apache.cloudstack.network.contrail.mod= el.ModelObject)() >=20 > ** CID 1164012: Explicit null dereferenced (FORWARD_NULL) > /plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/Hyper= vDirectConnectResource.java: 1730 in com.cloud.hypervisor.hyperv.resource.Hy= pervDirectConnectResource.postHttpRequest(java.lang.String, java.net.URI)() >=20 > ** CID 1164009: Explicit null dereferenced (FORWARD_NULL) > /engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java: 332= 1 in com.cloud.vm.VirtualMachineManagerImpl.removeNicFromVm(com.cloud.vm.Vir= tualMachine, com.cloud.vm.Nic)() >=20 > ** CID 1164010: Explicit null dereferenced (FORWARD_NULL) > /engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java: 320= 9 in com.cloud.vm.VirtualMachineManagerImpl.addVmToNetwork(com.cloud.vm.Virt= ualMachine, com.cloud.network.Network, com.cloud.vm.NicProfile)() >=20 > ** CID 1164015: Explicit null dereferenced (FORWARD_NULL) > /engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java: 130= 8 in com.cloud.vm.VirtualMachineManagerImpl.advanceStop(java.lang.String, bo= olean)() >=20 > ** CID 1164011: Explicit null dereferenced (FORWARD_NULL) > /engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java: 383= 0 in com.cloud.vm.VirtualMachineManagerImpl.reConfigureVm(java.lang.String, c= om.cloud.offering.ServiceOffering, boolean)() >=20 > ** CID 1164008: Explicit null dereferenced (FORWARD_NULL) > /engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java: 161= 1 in com.cloud.vm.VirtualMachineManagerImpl.storageMigration(java.lang.Strin= g, com.cloud.storage.StoragePool)() >=20 > ** CID 1164014: Explicit null dereferenced (FORWARD_NULL) > /engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java: 198= 5 in com.cloud.vm.VirtualMachineManagerImpl.migrateWithStorage(java.lang.Str= ing, long, long, java.util.Map)() >=20 > ** CID 1164007: Explicit null dereferenced (FORWARD_NULL) > /engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java: 227= 9 in com.cloud.vm.VirtualMachineManagerImpl.advanceReboot(java.lang.String, j= ava.util.Map)() >=20 > ** CID 1164006: Explicit null dereferenced (FORWARD_NULL) > /engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java: 170= 3 in com.cloud.vm.VirtualMachineManagerImpl.migrate(java.lang.String, long, c= om.cloud.deploy.DeployDestination)() >=20 > ** CID 1164005: Explicit null dereferenced (FORWARD_NULL) > /engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java: 357= 1 in com.cloud.vm.VirtualMachineManagerImpl.migrateForScale(java.lang.String= , long, com.cloud.deploy.DeployDestination, java.lang.Long)() >=20 > ** CID 1164004: Explicit null dereferenced (FORWARD_NULL) > /engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java: 766= in com.cloud.vm.VirtualMachineManagerImpl.advanceStart(java.lang.String, ja= va.util.Map, com.cloud.deploy.DeploymentPlan, com.cloud.deploy.DeploymentPla= nner)() >=20 > ** CID 1164003: Dereference after null check (FORWARD_NULL) > /plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/netwo= rk/contrail/model/ServiceInstanceModel.java: 90 in org.apache.cloudstack.net= work.contrail.model.ServiceInstanceModel.(net.juniper.contrail.api.typ= es.Project, java.lang.String, com.cloud.template.VirtualMachineTemplate, com= .cloud.offering.ServiceOffering, org.apache.cloudstack.network.contrail.mode= l.VirtualNetworkModel, org.apache.cloudstack.network.contrail.model.VirtualN= etworkModel)() >=20 > ** CID 1125352: Dereference after null check (FORWARD_NULL) > /plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/netwo= rk/contrail/model/VirtualMachineModel.java: 113 in org.apache.cloudstack.net= work.contrail.model.VirtualMachineModel.buildServiceInstance(org.apache.clou= dstack.network.contrail.model.ModelController, java.lang.String)() >=20 >=20 > __________________________________________________________________________= ______________________________ > *** CID 1164002: Logically dead code (DEADCODE) > /server/src/com/cloud/api/query/dao/TemplateJoinDaoImpl.java: 388 in com.c= loud.api.query.dao.TemplateJoinDaoImpl.searchByTemplateZonePair(java.lang.Bo= olean, java.lang.String[])() > 382 String batchCfg =3D _configDao.getValue("detail.batch.quer= y.size"); > 383 if (batchCfg !=3D null) { > 384 DETAILS_BATCH_SIZE =3D Integer.parseInt(batchCfg); > 385 } > 386 // query details by batches > 387 Boolean isAscending =3D Boolean.parseBoolean(_configDao.ge= tValue("sortkey.algorithm")); >>>> CID 1164002: Logically dead code (DEADCODE) >>>> Execution cannot reach this expression "true" inside statement "isAs= cending =3D ((isAscending...". > 388 isAscending =3D (isAscending =3D=3D null ? true : isAscend= ing); > 389 Filter searchFilter =3D new Filter(TemplateJoinVO.class, "= sortKey", isAscending, null, null); > 390 List uvList =3D new ArrayList(); > 391 // query details by batches > 392 int curr_index =3D 0; > 393 if (idPairs.length > DETAILS_BATCH_SIZE) { >=20 > __________________________________________________________________________= ______________________________ > *** CID 1164018: Explicit null dereferenced (FORWARD_NULL) > /server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java: 730 in com.c= loud.vm.snapshot.VMSnapshotManagerImpl.deleteAllVMSnapshots(long, com.cloud.= vm.snapshot.VMSnapshot$Type)() > 724 placeHolder =3D createPlaceHolderWork(vmId); > 725 } > 726 try { > 727 return orchestrateDeleteAllVMSnapshots(vmId, type)= ; > 728 } finally { > 729 if (VmJobEnabled.value()) >>>> CID 1164018: Explicit null dereferenced (FORWARD_NULL) >>>> Calling a method on null object "placeHolder". > 730 _workJobDao.expunge(placeHolder.getId()); > 731 } > 732 =20 > 733 } else { > 734 Outcome outcome =3D deleteAllVMSnapsho= tsThroughJobQueue(vmId, type); > 735 =20 >=20 > __________________________________________________________________________= ______________________________ > *** CID 1164020: Explicit null dereferenced (FORWARD_NULL) > /server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java: 478 in com.c= loud.vm.snapshot.VMSnapshotManagerImpl.deleteVMSnapshot(java.lang.Long)() > 472 placeHolder =3D createPlaceHolderWork(vmSnapshot.g= etVmId()); > 473 } > 474 try { > 475 return orchestrateDeleteVMSnapshot(vmSnapshotId); > 476 } finally { > 477 if (VmJobEnabled.value()) >>>> CID 1164020: Explicit null dereferenced (FORWARD_NULL) >>>> Calling a method on null object "placeHolder". > 478 _workJobDao.expunge(placeHolder.getId()); > 479 } > 480 } else { > 481 Outcome outcome =3D deleteVMSnapshotThroug= hJobQueue(vmSnapshot.getVmId(), vmSnapshotId); > 482 =20 > 483 VMSnapshot result =3D null; >=20 > __________________________________________________________________________= ______________________________ > *** CID 1164017: Explicit null dereferenced (FORWARD_NULL) > /server/src/com/cloud/storage/VolumeApiServiceImpl.java: 1619 in com.cloud= .storage.VolumeApiServiceImpl.migrateVolume(org.apache.cloudstack.api.comman= d.user.volume.MigrateVolumeCmd)() > 1613 placeHolder =3D createPlaceHolderWork(vm.getI= d()); > 1614 } > 1615 try { > 1616 return orchestrateMigrateVolume(vol.getId(), d= estPool.getId(), liveMigrateVolume); > 1617 } finally { > 1618 if (VmJobEnabled.value()) >>>> CID 1164017: Explicit null dereferenced (FORWARD_NULL) >>>> Calling a method on null object "placeHolder". > 1619 _workJobDao.expunge(placeHolder.getId());= > 1620 } > 1621 =20 > 1622 } else { > 1623 Outcome outcome =3D migrateVolumeThroughJ= obQueue(vm.getId(), vol.getId(), destPool.getId(), liveMigrateVolume); > 1624 =20 >=20 > __________________________________________________________________________= ______________________________ > *** CID 1164019: Explicit null dereferenced (FORWARD_NULL) > /server/src/com/cloud/storage/VolumeApiServiceImpl.java: 1721 in com.cloud= .storage.VolumeApiServiceImpl.takeSnapshot(java.lang.Long, java.lang.Long, j= ava.lang.Long, com.cloud.user.Account, boolean)() > 1715 placeHolder =3D createPlaceHolderWork(vm.getI= d()); > 1716 } > 1717 try { > 1718 return orchestrateTakeVolumeSnapshot(volumeId= , policyId, snapshotId, account, quiescevm); > 1719 } finally { > 1720 if (VmJobEnabled.value()) >>>> CID 1164019: Explicit null dereferenced (FORWARD_NULL) >>>> Calling a method on null object "placeHolder". > 1721 _workJobDao.expunge(placeHolder.getId());= > 1722 } > 1723 =20 > 1724 } else { > 1725 Outcome outcome =3D takeVolumeSnapshotT= hroughJobQueue(vm.getId(), volumeId, policyId, snapshotId, account.getId(), q= uiescevm); > 1726 =20 >=20 > __________________________________________________________________________= ______________________________ > *** CID 1164016: Dereference after null check (FORWARD_NULL) > /server/src/com/cloud/storage/VolumeApiServiceImpl.java: 2033 in com.cloud= .storage.VolumeApiServiceImpl.sendAttachVolumeCommand(com.cloud.vm.UserVmVO,= com.cloud.storage.VolumeVO, java.lang.Long)() > 2027 =20 > 2028 throw new CloudRuntimeException(e.getMessage()); > 2029 } > 2030 } > 2031 =20 > 2032 if (sendCommand) { >>>> CID 1164016: Dereference after null check (FORWARD_NULL) >>>> Calling a method on null object "volumeToAttachStoragePool". > 2033 if (host.getHypervisorType() =3D=3D HypervisorType.KV= M && > 2034 volumeToAttachStoragePool.isManaged() && > 2035 volumeToAttach.getPath() =3D=3D null) { > 2036 volumeToAttach.setPath(volumeToAttach.get_iScsiNa= me()); > 2037 =20 > 2038 _volsDao.update(volumeToAttach.getId(), volumeToA= ttach); >=20 > __________________________________________________________________________= ______________________________ > *** CID 1164013: Dereference after null check (FORWARD_NULL) > /plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/netwo= rk/contrail/model/VirtualNetworkModel.java: 535 in org.apache.cloudstack.net= work.contrail.model.VirtualNetworkModel.compare(org.apache.cloudstack.networ= k.contrail.model.ModelController, org.apache.cloudstack.network.contrail.mod= el.ModelObject)() > 529 ObjectReference ref2 =3D latestP= olicyRefs.get(0); > 530 =20 > 531 if ((ref1 !=3D null && ref2 =3D=3D null) || (ref1 =3D=3D n= ull && ref2 !=3D null)) { > 532 return false; > 533 } > 534 =20 >>>> CID 1164013: Dereference after null check (FORWARD_NULL) >>>> Calling a method on null object "ref1". > 535 if ((ref1.getUuid() !=3D null && ref2.getUuid() =3D=3D nul= l) || (ref1.getUuid() =3D=3D null && ref2.getUuid() !=3D null)) { > 536 return false; > 537 } > 538 if (ref1.getUuid() =3D=3D null && ref2.getUuid() =3D=3D nu= ll) { > 539 return true; > 540 } >=20 > __________________________________________________________________________= ______________________________ > *** CID 1164012: Explicit null dereferenced (FORWARD_NULL) > /plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/Hyper= vDirectConnectResource.java: 1730 in com.cloud.hypervisor.hyperv.resource.Hy= pervDirectConnectResource.postHttpRequest(java.lang.String, java.net.URI)() > 1724 // large data transfers > 1725 StringEntity cmdJson =3D new StringEntity(jsonCmd); > 1726 request.addHeader("content-type", "application/json")= ; > 1727 request.setEntity(cmdJson); > 1728 s_logger.debug("Sending cmd to " + agentUri.toString(= ) > 1729 + " cmd data:" + logMessage); >>>> CID 1164012: Explicit null dereferenced (FORWARD_NULL) >>>> Calling a method on null object "httpClient". > 1730 HttpResponse response =3D httpClient.execute(request)= ; > 1731 =20 > 1732 // Unsupported commands will not route. > 1733 if (response.getStatusLine().getStatusCode() =3D=3D H= ttpStatus.SC_NOT_FOUND) { > 1734 String errMsg =3D "Failed to send : HTTP error co= de : " + response.getStatusLine().getStatusCode(); > 1735 s_logger.error(errMsg); >=20 > __________________________________________________________________________= ______________________________ > *** CID 1164009: Explicit null dereferenced (FORWARD_NULL) > /engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java: 332= 1 in com.cloud.vm.VirtualMachineManagerImpl.removeNicFromVm(com.cloud.vm.Vir= tualMachine, com.cloud.vm.Nic)() > 3315 placeHolder =3D createPlaceHolderWork(vm.getId())= ; > 3316 } > 3317 try { > 3318 return orchestrateRemoveNicFromVm(vm, nic); > 3319 } finally { > 3320 if (VmJobEnabled.value()) >>>> CID 1164009: Explicit null dereferenced (FORWARD_NULL) >>>> Calling a method on null object "placeHolder". > 3321 _workJobDao.expunge(placeHolder.getId()); > 3322 } > 3323 =20 > 3324 } else { > 3325 Outcome outcome =3D removeNicFromVmTh= roughJobQueue(vm, nic); > 3326 =20 >=20 > __________________________________________________________________________= ______________________________ > *** CID 1164010: Explicit null dereferenced (FORWARD_NULL) > /engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java: 320= 9 in com.cloud.vm.VirtualMachineManagerImpl.addVmToNetwork(com.cloud.vm.Virt= ualMachine, com.cloud.network.Network, com.cloud.vm.NicProfile)() > 3203 placeHolder =3D createPlaceHolderWork(vm.getId())= ; > 3204 } > 3205 try { > 3206 return orchestrateAddVmToNetwork(vm, network, req= uested); > 3207 } finally { > 3208 if (VmJobEnabled.value()) >>>> CID 1164010: Explicit null dereferenced (FORWARD_NULL) >>>> Calling a method on null object "placeHolder". > 3209 _workJobDao.expunge(placeHolder.getId()); > 3210 } > 3211 } else { > 3212 Outcome outcome =3D addVmToNetworkThr= oughJobQueue(vm, network, requested); > 3213 =20 > 3214 try { >=20 > __________________________________________________________________________= ______________________________ > *** CID 1164015: Explicit null dereferenced (FORWARD_NULL) > /engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java: 130= 8 in com.cloud.vm.VirtualMachineManagerImpl.advanceStop(java.lang.String, bo= olean)() > 1302 placeHolder =3D createPlaceHolderWork(vm.getId())= ; > 1303 } > 1304 try { > 1305 orchestrateStop(vmUuid, cleanUpEvenIfUnableToStop= ); > 1306 } finally { > 1307 if (VmJobEnabled.value()) >>>> CID 1164015: Explicit null dereferenced (FORWARD_NULL) >>>> Calling a method on null object "placeHolder". > 1308 _workJobDao.expunge(placeHolder.getId()); > 1309 } > 1310 =20 > 1311 } else { > 1312 Outcome outcome =3D stopVmThroughJobQ= ueue(vmUuid, cleanUpEvenIfUnableToStop); > 1313 =20 >=20 > __________________________________________________________________________= ______________________________ > *** CID 1164011: Explicit null dereferenced (FORWARD_NULL) > /engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java: 383= 0 in com.cloud.vm.VirtualMachineManagerImpl.reConfigureVm(java.lang.String, c= om.cloud.offering.ServiceOffering, boolean)() > 3824 placeHolder =3D createPlaceHolderWork(vm.getId())= ; > 3825 } > 3826 try { > 3827 return orchestrateReConfigureVm(vmUuid, oldServic= eOffering, reconfiguringOnExistingHost); > 3828 } finally { > 3829 if (VmJobEnabled.value()) >>>> CID 1164011: Explicit null dereferenced (FORWARD_NULL) >>>> Calling a method on null object "placeHolder". > 3830 _workJobDao.expunge(placeHolder.getId()); > 3831 } > 3832 } else { > 3833 Outcome outcome =3D reconfigureVmThro= ughJobQueue(vmUuid, oldServiceOffering, reconfiguringOnExistingHost); > 3834 =20 > 3835 VirtualMachine vm =3D null; >=20 > __________________________________________________________________________= ______________________________ > *** CID 1164008: Explicit null dereferenced (FORWARD_NULL) > /engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java: 161= 1 in com.cloud.vm.VirtualMachineManagerImpl.storageMigration(java.lang.Strin= g, com.cloud.storage.StoragePool)() > 1605 placeHolder =3D createPlaceHolderWork(vm.getId())= ; > 1606 } > 1607 try { > 1608 orchestrateStorageMigration(vmUuid, destPool); > 1609 } finally { > 1610 if (VmJobEnabled.value()) >>>> CID 1164008: Explicit null dereferenced (FORWARD_NULL) >>>> Calling a method on null object "placeHolder". > 1611 _workJobDao.expunge(placeHolder.getId()); > 1612 } > 1613 } else { > 1614 Outcome outcome =3D migrateVmStorageT= hroughJobQueue(vmUuid, destPool); > 1615 =20 > 1616 try { >=20 > __________________________________________________________________________= ______________________________ > *** CID 1164014: Explicit null dereferenced (FORWARD_NULL) > /engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java: 198= 5 in com.cloud.vm.VirtualMachineManagerImpl.migrateWithStorage(java.lang.Str= ing, long, long, java.util.Map)() > 1979 placeHolder =3D createPlaceHolderWork(vm.getId())= ; > 1980 } > 1981 try { > 1982 orchestrateMigrateWithStorage(vmUuid, srcHostId, d= estHostId, volumeToPool); > 1983 } finally { > 1984 if (VmJobEnabled.value()) >>>> CID 1164014: Explicit null dereferenced (FORWARD_NULL) >>>> Calling a method on null object "placeHolder". > 1985 _workJobDao.expunge(placeHolder.getId()); > 1986 } > 1987 =20 > 1988 } else { > 1989 Outcome outcome =3D migrateVmWithStor= ageThroughJobQueue(vmUuid, srcHostId, destHostId, volumeToPool); > 1990 =20 >=20 > __________________________________________________________________________= ______________________________ > *** CID 1164007: Explicit null dereferenced (FORWARD_NULL) > /engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java: 227= 9 in com.cloud.vm.VirtualMachineManagerImpl.advanceReboot(java.lang.String, j= ava.util.Map)() > 2273 placeHolder =3D createPlaceHolderWork(vm.getId())= ; > 2274 } > 2275 try { > 2276 orchestrateReboot(vmUuid, params); > 2277 } finally { > 2278 if (VmJobEnabled.value()) >>>> CID 1164007: Explicit null dereferenced (FORWARD_NULL) >>>> Calling a method on null object "placeHolder". > 2279 _workJobDao.expunge(placeHolder.getId()); > 2280 } > 2281 } else { > 2282 Outcome outcome =3D rebootVmThroughJo= bQueue(vmUuid, params); > 2283 =20 > 2284 try { >=20 > __________________________________________________________________________= ______________________________ > *** CID 1164006: Explicit null dereferenced (FORWARD_NULL) > /engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java: 170= 3 in com.cloud.vm.VirtualMachineManagerImpl.migrate(java.lang.String, long, c= om.cloud.deploy.DeployDestination)() > 1697 placeHolder =3D createPlaceHolderWork(vm.getId())= ; > 1698 } > 1699 try { > 1700 orchestrateMigrate(vmUuid, srcHostId, dest); > 1701 } finally { > 1702 if (VmJobEnabled.value()) >>>> CID 1164006: Explicit null dereferenced (FORWARD_NULL) >>>> Calling a method on null object "placeHolder". > 1703 _workJobDao.expunge(placeHolder.getId()); > 1704 } > 1705 } else { > 1706 Outcome outcome =3D migrateVmThroughJ= obQueue(vmUuid, srcHostId, dest); > 1707 =20 > 1708 try { >=20 > __________________________________________________________________________= ______________________________ > *** CID 1164005: Explicit null dereferenced (FORWARD_NULL) > /engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java: 357= 1 in com.cloud.vm.VirtualMachineManagerImpl.migrateForScale(java.lang.String= , long, com.cloud.deploy.DeployDestination, java.lang.Long)() > 3565 placeHolder =3D createPlaceHolderWork(vm.getId())= ; > 3566 } > 3567 try { > 3568 orchestrateMigrateForScale(vmUuid, srcHostId, des= t, oldSvcOfferingId); > 3569 } finally { > 3570 if (VmJobEnabled.value()) >>>> CID 1164005: Explicit null dereferenced (FORWARD_NULL) >>>> Calling a method on null object "placeHolder". > 3571 _workJobDao.expunge(placeHolder.getId()); > 3572 } > 3573 } else { > 3574 Outcome outcome =3D migrateVmForScale= ThroughJobQueue(vmUuid, srcHostId, dest, oldSvcOfferingId); > 3575 =20 > 3576 try { >=20 > __________________________________________________________________________= ______________________________ > *** CID 1164004: Explicit null dereferenced (FORWARD_NULL) > /engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java: 766= in com.cloud.vm.VirtualMachineManagerImpl.advanceStart(java.lang.String, ja= va.util.Map, com.cloud.deploy.DeploymentPlan, com.cloud.deploy.DeploymentPla= nner)() > 760 placeHolder =3D createPlaceHolderWork(vm.getId());= > 761 } > 762 try { > 763 orchestrateStart(vmUuid, params, planToDeploy, pla= nner); > 764 } finally { > 765 if (VmJobEnabled.value()) >>>> CID 1164004: Explicit null dereferenced (FORWARD_NULL) >>>> Calling a method on null object "placeHolder". > 766 _workJobDao.expunge(placeHolder.getId()); > 767 } > 768 } else { > 769 Outcome outcome =3D startVmThroughJobQ= ueue(vmUuid, params, planToDeploy); > 770 =20 > 771 try { >=20 > __________________________________________________________________________= ______________________________ > *** CID 1164003: Dereference after null check (FORWARD_NULL) > /plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/netwo= rk/contrail/model/ServiceInstanceModel.java: 90 in org.apache.cloudstack.net= work.contrail.model.ServiceInstanceModel.(net.juniper.contrail.api.typ= es.Project, java.lang.String, com.cloud.template.VirtualMachineTemplate, com= .cloud.offering.ServiceOffering, org.apache.cloudstack.network.contrail.mode= l.VirtualNetworkModel, org.apache.cloudstack.network.contrail.model.VirtualN= etworkModel)() > 84 _rightName =3D StringUtils.join(right.getVirtualNetwork().g= etQualifiedName(), ":"); > 85 =20 > 86 _templateName =3D template.getName(); > 87 _templateId =3D template.getUuid(); > 88 _templateUrl =3D template.getUrl(); > 89 =20 >>>> CID 1164003: Dereference after null check (FORWARD_NULL) >>>> Calling a method on null object "project". > 90 _projectId =3D project.getUuid(); > 91 } > 92 =20 > 93 /** > 94 * Create an empty ServiceInstance. > 95 * @param uuid >=20 > __________________________________________________________________________= ______________________________ > *** CID 1125352: Dereference after null check (FORWARD_NULL) > /plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/netwo= rk/contrail/model/VirtualMachineModel.java: 113 in org.apache.cloudstack.net= work.contrail.model.VirtualMachineModel.buildServiceInstance(org.apache.clou= dstack.network.contrail.model.ModelController, java.lang.String)() > 107 siObj =3D (ServiceInstance) api.findById(ServiceInstan= ce.class, serviceUuid); > 108 } catch (IOException ex) { > 109 s_logger.warn("service-instance read", ex); > 110 throw new CloudRuntimeException("Unable to read servic= e-instance object", ex); > 111 } > 112 ServiceInstanceModel siModel; >>>> CID 1125352: Dereference after null check (FORWARD_NULL) >>>> Comparing "siObj" to null implies that "siObj" might be null. > 113 if (siObj =3D=3D null) { > 114 siModel =3D new ServiceInstanceModel(serviceUuid); > 115 siModel.build(controller, siObj); > 116 manager.getDatabase().getServiceInstances().add(siMode= l); > 117 } else { > 118 String fqn =3D StringUtils.join(siObj.getQualifiedName= (), ':'); >=20 >=20 > __________________________________________________________________________= ______________________________ > To view the defects in Coverity Scan visit, http://scan.coverity.com/proje= cts/943?tab=3DOverview >=20 > To unsubscribe from the email notification for new defects, http://scan5.c= overity.com/cgi-bin/unsubscribe.py >=20 >=20 >=20 --Apple-Mail-4CAE4279-5D87-426E-A4EB-B488F8F3E083--