Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============5278307539695892629=="
MIME-Version: 1.0
Subject: Re: Review Request 16249: CLOUDSTACK-5496 : Account included in
 ActionEvents
 is Project Account ID
From: "ASF Subversion and Git Services" <asfbot@urd.zones.apache.org>
To: "Murali Reddy" <muralimmreddy@gmail.com>
Cc: "ASF Subversion and Git Services" <asfbot@urd.zones.apache.org>,
 "David Grizzanti" <david.grizzanti@sungard.com>,
 "cloudstack" <dev@cloudstack.apache.org>
Date: Thu, 30 Jan 2014 12:05:58 -0000
Message-ID: <20140130120558.21445.73335@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "ASF Subversion and Git Services" <noreply@reviews.apache.org>
References: <20140122140716.28235.87914@reviews.apache.org>
In-Reply-To: <20140122140716.28235.87914@reviews.apache.org>
Reply-To: "ASF Subversion and Git Services" <asfbot@urd.zones.apache.org>

--===============5278307539695892629==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16249/#review33215
-----------------------------------------------------------


Commit 5de9ae0bceddd751ae7f59fa4b7aec1d13f8bf59 in branch refs/heads/master from David Grizzanti
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5de9ae0 ]

CLOUDSTACK-5496 : Account included in ActionEvents is Project Account ID

When Action Events are generated and placed on the Event Bus, an
"account" parameter is included with the event. When these events are
generated for resources within projects, this "account" parameter is not
useful as it's the UUID of the project account, instead of the project.

To solve this, I updated ActionEventsUtil class to include a "project"
parameter in the generated events when the resource is being
changed/add/deleted in a project.


- ASF Subversion and Git Services


On Jan. 22, 2014, 2:07 p.m., David Grizzanti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16249/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2014, 2:07 p.m.)
> 
> 
> Review request for cloudstack and Murali Reddy.
> 
> 
> Bugs: CLOUDSTACK-5496
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5496
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-5496 : Account included in ActionEvents is Project Account ID
> 
> When Action Events are generated and placed on the Event Bus, an "account" parameter is included with the event. When these events are generated for resources within projects, this "account" parameter is not useful as it's the UUID of the project account, instead of the project. 
> 
> To solve this, I updated ActionEventsUtil class to include a "project" parameter in the generated events when the resource is being changed/add/deleted in a project.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/event/ActionEventUtils.java 0363a0d 
>   server/test/org/apache/cloudstack/affinity/AffinityApiUnitTest.java 061fd42 
> 
> Diff: https://reviews.apache.org/r/16249/diff/
> 
> 
> Testing
> -------
> 
> Testing done 4.2
> 
> 
> Thanks,
> 
> David Grizzanti
> 
>


--===============5278307539695892629==--