Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3F1A910A98 for ; Wed, 15 Jan 2014 01:31:58 +0000 (UTC) Received: (qmail 20364 invoked by uid 500); 15 Jan 2014 01:31:57 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 20281 invoked by uid 500); 15 Jan 2014 01:31:57 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 20271 invoked by uid 99); 15 Jan 2014 01:31:57 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Jan 2014 01:31:57 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B4EEA1D42F5; Wed, 15 Jan 2014 01:31:56 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0648530939306777545==" MIME-Version: 1.0 Subject: Re: Review Request 16813: Contrail plugin fixes From: "Sheng Yang" To: "Suresh Balineni" , "cloudstack" , "Sheng Yang" Date: Wed, 15 Jan 2014 01:31:56 -0000 Message-ID: <20140115013156.32581.14640@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Sheng Yang" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/16813/ X-Sender: "Sheng Yang" References: <20140114225620.11940.65065@reviews.apache.org> In-Reply-To: <20140114225620.11940.65065@reviews.apache.org> Reply-To: "Sheng Yang" X-ReviewRequest-Repository: cloudstack-git --===============0648530939306777545== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16813/#review31839 ----------------------------------------------------------- I didn't see the updated patch. Both attached file and diff are old with transactions. - Sheng Yang On Jan. 14, 2014, 10:56 p.m., Suresh Balineni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16813/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2014, 10:56 p.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > ------- > > Contrail plugin fixes > - this patch is already applied to 4.3 > - a master branch patch. > > > > Diffs > ----- > > api/src/com/cloud/network/Network.java 0b76789 > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java 5adbacd > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java 079035b > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java 335299e > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java ed58594 > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java e2845b7 > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java 52fe31e > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java 5030bb7 > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java 98be288 > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/NetworkPolicyModel.java PRE-CREATION > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java a9bc5c1 > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java df0af90 > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java 547d4bd > plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java 806dd21 > plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java fff4e5a > > Diff: https://reviews.apache.org/r/16813/diff/ > > > Testing > ------- > > compiled and verified locally > > > File Attachments > ---------------- > > Contrail fixes master branch - with fix for sheng review comment > https://reviews.apache.org/media/uploaded/files/2014/01/14/26c95dad-b064-4e66-8128-08d786858cc6__master.patch > > > Thanks, > > Suresh Balineni > > --===============0648530939306777545==--