Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C653E1056D for ; Tue, 14 Jan 2014 23:03:06 +0000 (UTC) Received: (qmail 69823 invoked by uid 500); 14 Jan 2014 23:03:05 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 69759 invoked by uid 500); 14 Jan 2014 23:03:05 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 69749 invoked by uid 99); 14 Jan 2014 23:03:05 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Jan 2014 23:03:05 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id EDE9C1D42E8; Tue, 14 Jan 2014 23:03:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5852307063455678886==" MIME-Version: 1.0 Subject: Re: Review Request 16805: Contrail plugin fixes - db update, policy port end fix From: "Suresh Balineni" To: "Suresh Balineni" , "Sheng Yang" , "cloudstack" Date: Tue, 14 Jan 2014 23:03:04 -0000 Message-ID: <20140114230304.11940.74819@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Suresh Balineni" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/16805/ X-Sender: "Suresh Balineni" References: <20140112000821.18600.37822@reviews.apache.org> In-Reply-To: <20140112000821.18600.37822@reviews.apache.org> Reply-To: "Suresh Balineni" X-ReviewRequest-Repository: cloudstack-git --===============5852307063455678886== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16805/ ----------------------------------------------------------- (Updated Jan. 14, 2014, 11:03 p.m.) Review request for cloudstack. Changes ------- Hi Sheng, I updated the fix without db transaction wrappers. This is a 4.3 version of patch. Please review and ship it. Thanks, Suresh Repository: cloudstack-git Description ------- Contrail plugin fixes. - db updates must be done inside a transaction. - network policy port end type error. - default host contrail vnc is set to local host. This is considered if config is not present. Diffs (updated) ----- plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java 18e8bde plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java b7c0023 plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/NetworkPolicyModel.java d5a8722 Diff: https://reviews.apache.org/r/16805/diff/ Testing ------- verified locally. Thanks, Suresh Balineni --===============5852307063455678886==--