Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D59A410B2E for ; Sat, 11 Jan 2014 01:14:56 +0000 (UTC) Received: (qmail 73829 invoked by uid 500); 11 Jan 2014 01:14:56 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 73785 invoked by uid 500); 11 Jan 2014 01:14:56 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 73775 invoked by uid 99); 11 Jan 2014 01:14:56 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Jan 2014 01:14:56 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A97661D41FD; Sat, 11 Jan 2014 01:14:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1252306767813519076==" MIME-Version: 1.0 Subject: Re: Review Request 16642: Contrail plguin fixes for CS 4.3 From: "Sheng Yang" To: "Suresh Balineni" , "cloudstack" , "Sheng Yang" Date: Sat, 11 Jan 2014 01:14:55 -0000 Message-ID: <20140111011455.2688.87484@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Sheng Yang" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/16642/ X-Sender: "Sheng Yang" References: <20140111010002.1924.67162@reviews.apache.org> In-Reply-To: <20140111010002.1924.67162@reviews.apache.org> Reply-To: "Sheng Yang" X-ReviewRequest-Repository: cloudstack-git --===============1252306767813519076== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16642/#review31576 ----------------------------------------------------------- Ship it! Looks good now. Applied to 4.3 branch. - Sheng Yang On Jan. 11, 2014, 12:59 a.m., Suresh Balineni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16642/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2014, 12:59 a.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > ------- > > - Contrail plugin bug fixes for CS 4.3. > - Code cleanup. > - Most of the fixes are in plugin code. > > > Diffs > ----- > > api/src/com/cloud/network/Network.java 0d916ab > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java dfbe7d3 > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java ca53f41 > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java b96b00c > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java 4eaafca > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java f705f07 > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java 7a77040 > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java ec37440 > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java 47fc99e > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/NetworkPolicyModel.java PRE-CREATION > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java 20b80be > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java ec20a94 > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java b4968ac > plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java 86750ca > plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java 40cd1ea > > Diff: https://reviews.apache.org/r/16642/diff/ > > > Testing > ------- > > verified locally. > > > File Attachments > ---------------- > > Good file > https://reviews.apache.org/media/uploaded/files/2014/01/11/9ce72fe1-cb37-42c7-838b-395229b3e082__fixes.patch > > > Thanks, > > Suresh Balineni > > --===============1252306767813519076==--