Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E0F8F10A7A for ; Sat, 11 Jan 2014 00:51:28 +0000 (UTC) Received: (qmail 23233 invoked by uid 500); 11 Jan 2014 00:51:28 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 23200 invoked by uid 500); 11 Jan 2014 00:51:28 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 23190 invoked by uid 99); 11 Jan 2014 00:51:28 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Jan 2014 00:51:28 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D80B21D41FD; Sat, 11 Jan 2014 00:51:27 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6437690652929228681==" MIME-Version: 1.0 Subject: Re: Review Request 16642: Contrail plguin fixes for CS 4.3 From: "Suresh Balineni" To: "Suresh Balineni" , "Sheng Yang" , "cloudstack" Date: Sat, 11 Jan 2014 00:51:27 -0000 Message-ID: <20140111005127.2688.76500@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Suresh Balineni" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/16642/ X-Sender: "Suresh Balineni" References: <20140111004414.2688.10421@reviews.apache.org> In-Reply-To: <20140111004414.2688.10421@reviews.apache.org> Reply-To: "Suresh Balineni" X-ReviewRequest-Repository: cloudstack-git --===============6437690652929228681== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16642/ ----------------------------------------------------------- (Updated Jan. 11, 2014, 12:51 a.m.) Review request for cloudstack. Changes ------- Hi Sheng, Can you please use the attached file which is "fixes.patch" ? Thanks, Suresh Repository: cloudstack-git Description ------- - Contrail plugin bug fixes for CS 4.3. - Code cleanup. - Most of the fixes are in plugin code. Diffs ----- api/src/com/cloud/network/Network.java 0d916ab plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java dfbe7d3 plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java ca53f41 plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java b96b00c plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java 4eaafca plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java f705f07 plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java 7a77040 plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java ec37440 plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java 47fc99e plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/NetworkPolicyModel.java PRE-CREATION plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java 20b80be plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java ec20a94 plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java b4968ac plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java 86750ca plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java 40cd1ea Diff: https://reviews.apache.org/r/16642/diff/ Testing ------- verified locally. File Attachments (updated) ---------------- Use thief patch file https://reviews.apache.org/media/uploaded/files/2014/01/11/ed6deb38-08b3-4ee3-bf44-68f42dd7d335__fixes.patch Thanks, Suresh Balineni --===============6437690652929228681==--