Return-Path: 
 <dev-return-49578-apmail-cloudstack-dev-archive=cloudstack.apache.org@cloudstack.apache.org>
X-Original-To: apmail-cloudstack-dev-archive@www.apache.org
Delivered-To: apmail-cloudstack-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id DB2FA10581
	for <apmail-cloudstack-dev-archive@www.apache.org>;
 Tue,  7 Jan 2014 16:29:32 +0000 (UTC)
Received: (qmail 28270 invoked by uid 500); 7 Jan 2014 16:28:59 -0000
Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org
Received: (qmail 28177 invoked by uid 500); 7 Jan 2014 16:28:58 -0000
Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cloudstack.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cloudstack.apache.org>
List-Post: <mailto:dev@cloudstack.apache.org>
List-Id: <dev.cloudstack.apache.org>
Reply-To: dev@cloudstack.apache.org
Delivered-To: mailing list dev@cloudstack.apache.org
Received: (qmail 28096 invoked by uid 99); 7 Jan 2014 16:28:58 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Jan 2014 16:28:58 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id BA0E21D3FF3;
	Tue,  7 Jan 2014 16:28:57 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============4432610070322128894=="
MIME-Version: 1.0
Subject: Re: Review Request 16688: console-proxy add support of AltGr key and
 FR
 azerty keyboard
From: "Axel Delahaye" <axel.delahaye@worldline.com>
To: "Axel Delahaye" <axel.delahaye@worldline.com>,
 "cloudstack" <dev@cloudstack.apache.org>
Date: Tue, 07 Jan 2014 16:28:57 -0000
Message-ID: <20140107162857.1150.17187@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org
Auto-Submitted: auto-generated
Sender: "Axel Delahaye" <noreply@reviews.apache.org>
X-ReviewGroup: cloudstack
X-ReviewRequest-URL: https://reviews.apache.org/r/16688/
X-Sender: "Axel Delahaye" <noreply@reviews.apache.org>
References: <20140107162511.1151.9415@reviews.apache.org>
In-Reply-To: <20140107162511.1151.9415@reviews.apache.org>
Reply-To: "Axel Delahaye" <axel.delahaye@worldline.com>
X-ReviewRequest-Repository: cloudstack-git

--===============4432610070322128894==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16688/
-----------------------------------------------------------

(Updated Jan. 7, 2014, 4:28 p.m.)


Review request for cloudstack.


Repository: cloudstack-git


Description
-------

Firstly, I add a match condition 'altgr' for "Conditional mapping entry" in ajaxviwer.js.
altgr : <altgr state match condition>, -- match on altgr state

It works like the shift match condition.
shift : <shift state match condition>, -- match on shift state

Browser can't detect difference between AltGr and Ctrl+Alt pressed at the same time.
So when the modifier is 896, (Alt(512) + Ctrl(384)) I assume it is the AltGr key and 'altgr' condition will be true.

In the ajaxkey.js file you got for example:
{type: KEY_DOWN, code: 0x32, modifiers: 0, altgr: true}
to send the spécified key to vnc if user pressed the AltGr (or Ctrl+Alt) key

Secondly,
I wrote the French AZERTY translation table in ajaxkeys.js with the support of AltGr character (like #{}[]|,etc.)

For example the '#':

{keycode: 51, entry: [         //User type the "3# key and each condition match 'altgr'
{type: KEY_DOWN, code: 0xffea, modifiers: 0, altgr: true}, //press the VNC AltGR key
{type: KEY_DOWN, code: 0x33, modifiers: 0, altgr: true},   //press the 3 key
{type: KEY_UP, code: 0x33, modifiers: 0, altgr: true},     //release it
{type: KEY_UP, code: 0xffea, modifiers: 0, altgr: true}    //release the AltGr key
]},

I replace the Standard (US) keyboard translation table because I can't add an entry in the console proxy keyboard menu.

Thanks for watching my work

Axel Delahaye


Diffs
-----

  services/console-proxy/server/js/ajaxkeys.js 60c9798 
  services/console-proxy/server/js/ajaxviewer.js 9643204 

Diff: https://reviews.apache.org/r/16688/diff/


Testing
-------

Tested with
Hardware : French AZERTY keyboard
Software : Configured in windows as FR keyboard
Console-proxy : Customized Standard (US) keyboard
Guest : CentOS 6.5 , Debian 7 and FreeBSD 8
Guest keymap : fr, fr-pc

Only the "<" ">" key doesn't work


Thanks,

Axel Delahaye


--===============4432610070322128894==--