Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============7472590099166764748=="
MIME-Version: 1.0
Subject: Re: Review Request 16568: CLOUDSTACK-5633: Fixed network cleanup
 issue
From: "ASF Subversion and Git Services" <asfbot@urd.zones.apache.org>
To: "Girish Shilamkar" <girish@clogeny.com>
Cc: "Gaurav Aradhye" <gaurav.aradhye@clogeny.com>,
 "ASF Subversion and Git Services" <asfbot@urd.zones.apache.org>,
 "cloudstack" <dev@cloudstack.apache.org>
Date: Fri, 03 Jan 2014 05:46:11 -0000
Message-ID: <20140103054611.26158.23933@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "ASF Subversion and Git Services" <noreply@reviews.apache.org>
References: <20140102105214.1720.16106@reviews.apache.org>
In-Reply-To: <20140102105214.1720.16106@reviews.apache.org>
Reply-To: "ASF Subversion and Git Services" <asfbot@urd.zones.apache.org>

--===============7472590099166764748==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16568/#review31111
-----------------------------------------------------------


Commit 8fb02e35ef86ffc6300b5cae72e70e279db49a7b in branch refs/heads/4.3 from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8fb02e3 ]

CLOUDSTACK-5633: Fixed network cleanup issue


- ASF Subversion and Git Services


On Jan. 2, 2014, 10:52 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16568/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2014, 10:52 a.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-5633
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5633
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Network has been added twice in the cleanup list which leads to failure.
> 
> Changes:
> 1) Remove the extra entry of network in cleanup list.
> 2) Add Domain to cleanup list (was missing) instead of service offering belonging to domain (which will be automatically removed when domain is removed)
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_project_resources.py 1838269 
> 
> Diff: https://reviews.apache.org/r/16568/diff/
> 
> 
> Testing
> -------
> 
> Tested locally.
> 
> Log:
> test_03_network_create (test_project_resources_fixed.TestNetwork)
> Test create network in project ... ok
> test_01_service_offerings (test_project_resources_fixed.TestOfferings)
> Test service offerings in a project ... skipped 'skip'
> test_02_project_disk_offerings (test_project_resources_fixed.TestOfferings)
> Test project disk offerings ... skipped 'skip'
> test_07_associate_public_ip (test_project_resources_fixed.TestPublicIpAddress)
> Test associate public IP within the project ... skipped 'skip'
> test_08_security_group (test_project_resources_fixed.TestSecurityGroup)
> Test security groups in project ... skipped 'skip'
> test_06_create_snapshots_in_project (test_project_resources_fixed.TestSnapshots)
> Test create snapshots in project ... skipped 'skip'
> test_04_public_template_use_in_project (test_project_resources_fixed.TestTemplates)
> Test Templates creation in projects ... skipped 'skip'
> test_05_use_private_template_in_project (test_project_resources_fixed.TestTemplates)
> Test use of private template in a project ... skipped 'skip'
> 
> ----------------------------------------------------------------------
> Ran 8 tests in 452.545s
> 
> OK (skipped=7)
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


--===============7472590099166764748==--