From dev-return-50942-apmail-cloudstack-dev-archive=cloudstack.apache.org@cloudstack.apache.org Tue Jan 28 09:29:15 2014 Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 43D7D10CC0 for ; Tue, 28 Jan 2014 09:29:15 +0000 (UTC) Received: (qmail 59414 invoked by uid 500); 28 Jan 2014 09:29:14 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 58963 invoked by uid 500); 28 Jan 2014 09:29:12 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 58948 invoked by uid 99); 28 Jan 2014 09:29:11 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Jan 2014 09:29:11 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of trippie@gmail.com designates 209.85.215.182 as permitted sender) Received: from [209.85.215.182] (HELO mail-ea0-f182.google.com) (209.85.215.182) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Jan 2014 09:29:07 +0000 Received: by mail-ea0-f182.google.com with SMTP id r15so82694ead.41 for ; Tue, 28 Jan 2014 01:28:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:content-type:mime-version:subject:from:in-reply-to:date :content-transfer-encoding:message-id:references:to; bh=AMoslaGB27du6PDw82ULpqRrZynR3Sc8ptjkTDIzXYU=; b=MEuWA/mcRgOeVhWjesTh3Z4ci6GuOud/kQ5M0PUOU3cy0v9ylokGq+Q/WFjvVsQjkX Qjk/d9rDgQmjWyhGt72WgeRYliAAdiUswpmve8+23lV1g7jHlFQiUaiORGCEbHmw9TDh xv6X0ZUXdw4kRHLDdAhG+3fqAb9reWlsnkaezoO1uS0X7pYW4r4t3WlsRqRG5cBpVu51 hitST90FdpjzTtOZi4k6S0mlQNbPgH0vbyxjJwI06MoA4doL5e7ZZk4O7cSZsyxsINZk poSiZVp4LT5V4OE8+GqIfYKJKDrtgcGMFubKPa/+je8iEnZib+xVcAuJyOejJbL6hSPN 6Jkg== X-Received: by 10.14.113.199 with SMTP id a47mr588214eeh.41.1390901325742; Tue, 28 Jan 2014 01:28:45 -0800 (PST) Received: from [10.10.1.63] ([95.142.96.53]) by mx.google.com with ESMTPSA id w4sm53349122eef.20.2014.01.28.01.28.43 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 28 Jan 2014 01:28:44 -0800 (PST) Sender: Trippie Content-Type: text/plain; charset=iso-8859-1 Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) Subject: Re: Findbugs report on 4.3-forward From: Hugo Trippaers In-Reply-To: Date: Tue, 28 Jan 2014 10:28:42 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <8DB425D6-6300-4B26-80C3-11A4942011F1@GMAIL.com> References: <6DC27597-C1D4-49DA-AB81-933F32AC6758@GMAIL.com> To: dev X-Mailer: Apple Mail (2.1827) X-Virus-Checked: Checked by ClamAV on apache.org Hey Animesh, I agree with Daan here. We focussed on the bugs with a findbugs = annotation of scariest. I think that would warrant them to be included = in the 4.3 release, so please cherry-pick them all. Cheers, Hugo On 28 jan. 2014, at 09:32, Daan Hoogland = wrote: > Animesh, >=20 > I took up a lot of messages from findbugs in the server package over > the weekend. Not that I will attach my soul to the shipping of my > fixes but some of them are =3D=3D vs eq and some are really nasty > nullpointer issues (a chack after first use is very common). You can > cherry-pick them or not. I don't think you should leave any of them > behind. Even with David being right we should go against him at every > convenient time, running the risk of being called his wife. >=20 > On Tue, Jan 28, 2014 at 6:25 AM, Ian Duffy wrote: >> Hi Animesh, >>=20 >> Can you cherry-pick the below commit from from 4.3-forward to 4.3 = branch? >>=20 >> Fix findbug issues within LDAP authenticator >> commit 92b4f66d73562e4211d2d787554ff229dbeb5705 >>=20 >> Thanks, >> Ian >>=20 >> On 28 January 2014 03:48, Animesh Chaturvedi >> wrote: >>=20 >>> Hugo I was reviewing your commits to 4.3-forward and looked at your = commits >>>=20 >>>=20 >>> = https://git-wip-us.apache.org/repos/asf?p=3Dcloudstack.git;a=3Dcommit;h=3D= f18c5a1910b6370585a1d61638b8310c3ecba5ef >>>=20 >>> = https://git-wip-us.apache.org/repos/asf?p=3Dcloudstack.git;a=3Dcommit;h=3D= 60ac12780bfa1604902a89d5dc7937a8b9334e0d >>> I think you want the last one which has fixes for NetUtils and >>> XenServerStorageMotionStrategy for which you had put -1 in first RC = but the >>> commit includes more files. Can you make limited changes directly to = 4.3? I >>> want to build another RC later tonight >>>=20 >>> Animesh >>>=20 >>>=20 >>> -----Original Message----- >>> From: Animesh Chaturvedi [mailto:animesh.chaturvedi@citrix.com] >>> Sent: Monday, January 27, 2014 1:30 PM >>> To: dev@cloudstack.apache.org >>> Subject: RE: Findbugs report on 4.3-forward >>>=20 >>> Agreed >>>=20 >>> We need to fix the most important ones for 4.3. There may be = assumptions >>> in the code which we may not know and may get broken if these issues = are >>> fixed late. I will pull in the one Hugo casted his -1 for the first = vote, >>> any others? >>>=20 >>> Animesh >>>=20 >>> -----Original Message----- >>> From: David Nalley [mailto:david@gnsa.us] >>> Sent: Monday, January 27, 2014 11:46 AM >>> To: dev@cloudstack.apache.org >>> Subject: Re: Findbugs report on 4.3-forward >>>=20 >>> So just curious if I am the only one concerned about a ton of fixes = going >>> in at the last minute. If the fixes are for serious bugs and we have >>> consensus around their severity being high enough, indeed lets fix = things. >>> My concern is that much of the QA we do is manual; and while we are = getting >>> better; fixing tons of things at the last minute may have unintended >>> consequences that we don't know about and won't easily find. >>>=20 >>> I yearn for the day when our automated testing is broad enough that = we can >>> do fixes right up to the wire and know that things still work, I am = just >>> not sure that I have confidence that we are there yet. >>> Thoughts? I am being paranoid? >>>=20 >>> --David >>>=20 >>> On Mon, Jan 27, 2014 at 3:11 AM, Daan Hoogland = >>> wrote: >>>> Animesh, I commented the once i made yesterday with findbugs: >>>>=20 >>>> I allready send a few and will get you a list of the rest later = today. >>>>=20 >>>> regards, >>>>=20 >>>> On Mon, Jan 27, 2014 at 3:48 AM, Animesh Chaturvedi >>>> wrote: >>>>> Good job fellas. I see a number of commits 20+ into 4.3-forward = branch. >>> Are their specific commits you want me to pick up out of these? >>>>>=20 >>>>> Animesh >>>>>=20 >>>>> -----Original Message----- >>>>> From: Daan Hoogland [mailto:daan.hoogland@gmail.com] >>>>> Sent: Sunday, January 26, 2014 2:41 AM >>>>> To: dev >>>>> Subject: Re: Findbugs report on 4.3-forward >>>>>=20 >>>>> I didn't get very far last night and will be looking at the server >>> package again this afternoon. >>>>>=20 >>>>> bon app=E9tit, >>>>>=20 >>>>> On Sun, Jan 26, 2014 at 1:36 AM, Ian Duffy = wrote: >>>>>> Hi, >>>>>>=20 >>>>>> Fixed the issues highlighted in the ldap user authentication = package. >>>>>>=20 >>>>>> Have pushed to 4.3-forward. >>>>>>=20 >>>>>> Thanks, >>>>>> Ian >>>>>>=20 >>>>>>=20 >>>>>> On 25 January 2014 22:26, Daan Hoogland >>> wrote: >>>>>>=20 >>>>>>>> or reply to this mail with the filename you are working on >>>>>>> I'll be looking at the server package as it seems to contain the >>>>>>> most issues. >>>>>>>=20 >>>>>>> On Sat, Jan 25, 2014 at 4:00 PM, Hugo Trippaers = >>> wrote: >>>>>>>> I've also added a job to master with the Findbugs report and = the >>>>>>> cobertura code coverage report. >>>>>>>>=20 >>>>>>>> Good stuff, we have a 12% coverage of our classes with unit = tests. >>>>>>>> Huge >>>>>>> improvement over the last release where we had 4% iirc. We have = 306 >>>>>>> reports from Findbugs, of which the majority are = internationalization >>> issues. >>>>>>> (String.getBytes without charset mostly). On the coverity site = we >>>>>>> have >>>>>>> 6000+ issues still open, but at least that number is relatively >>>>>>> 6000+ stable, we >>>>>>> fix as much issues as we introduce and it's untuned so we can >>>>>>> assume a large number of false positives there. >>>>>>>>=20 >>>>>>>> I think that on average the automated tools tell us that code >>>>>>>> quality is >>>>>>> improving, which a good thing. Combined with the functional = testing >>>>>>> and the simulator build we can prove that we are doing quite = well >>>>>>> on the code quality angle. >>>>>>>>=20 >>>>>>>> http://jenkins.buildacloud.org/job/build-master-slowbuild/ >>>>>>>>=20 >>>>>>>>=20 >>>>>>>> Cheers, >>>>>>>>=20 >>>>>>>> Hugo >>>>>>>>=20 >>>>>>>>=20 >>>>>>>> On 25 jan. 2014, at 14:13, Daan Hoogland >>>>>>>> >>>>>>> wrote: >>>>>>>>=20 >>>>>>>>> H Hugo, >>>>>>>>>=20 >>>>>>>>> I'll spend some time on it tonight. Do you have a work load >>>>>>>>> distribution scheme or is it random access? >>>>>>>>> ;) >>>>>>>>>=20 >>>>>>>>> regards >>>>>>>>>=20 >>>>>>>>> On Sat, Jan 25, 2014 at 12:39 PM, Hugo Trippaers >>>>>>>>> >>>>>>> wrote: >>>>>>>>>> Hey all, >>>>>>>>>>=20 >>>>>>>>>> I've made Jenkins run the findbugs analysis on 4.3-forward. = Is >>>>>>>>>> there >>>>>>> somebody who is willing to help triage the findings? Maybe there = is >>>>>>> some stuff that we need to fix? >>>>>>>>>>=20 >>>>>>>>>> the url is >>>>>>> = http://jenkins.buildacloud.org/job/cloudstack-4.3-forward-maven-bui >>>>>>> ld >>>>>>> /3/findbugsResult/ >>>>>>>>>>=20 >>>>>>>>>> Cheers, >>>>>>>>>>=20 >>>>>>>>>> Hugo >>>>>>>>=20 >>>>>>>=20 >>>=20