From dev-return-51053-apmail-cloudstack-dev-archive=cloudstack.apache.org@cloudstack.apache.org Wed Jan 29 05:32:00 2014 Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DAFE31068B for ; Wed, 29 Jan 2014 05:31:59 +0000 (UTC) Received: (qmail 84846 invoked by uid 500); 29 Jan 2014 05:31:58 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 84795 invoked by uid 500); 29 Jan 2014 05:31:56 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 84639 invoked by uid 99); 29 Jan 2014 05:31:55 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Jan 2014 05:31:55 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0D0FD1D46BB; Wed, 29 Jan 2014 05:31:54 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1877970865009693563==" MIME-Version: 1.0 Subject: Re: Review Request 17452: Added Fi for CLOUDSTACK-5963 From: "Girish Shilamkar" To: "Girish Shilamkar" Cc: "Santhosh Edukulla" , "cloudstack" Date: Wed, 29 Jan 2014 05:31:54 -0000 Message-ID: <20140129053154.6810.91664@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Girish Shilamkar" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/17452/ X-Sender: "Girish Shilamkar" References: <20140128104722.13731.28238@reviews.apache.org> In-Reply-To: <20140128104722.13731.28238@reviews.apache.org> Reply-To: "Girish Shilamkar" X-ReviewRequest-Repository: cloudstack-git --===============1877970865009693563== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17452/#review33099 ----------------------------------------------------------- Ship it! Ship It! - Girish Shilamkar On Jan. 28, 2014, 10:47 a.m., Santhosh Edukulla wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17452/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2014, 10:47 a.m.) > > > Review request for cloudstack and Girish Shilamkar. > > > Bugs: CLOUDSTACK-5963 > https://issues.apache.org/jira/browse/CLOUDSTACK-5963 > > > Repository: cloudstack-git > > > Description > ------- > > 1. The way we are verifying the response for test_public_ip_admin_account seems to have an issue, it should ideally check for empty list. > 2. Post the nat and firewall rule, still there could be a possibility such that the vm may not be in running state. We are not passing mode flag here as such for advanced zone. So explicit fail when vm status is not running post the ssh failure. > 3. try except block for nat rule deletion and listing. > 4. Adding a sleep post delete. > > > Diffs > ----- > > test/integration/smoke/test_network.py 732fe15 > > Diff: https://reviews.apache.org/r/17452/diff/ > > > Testing > ------- > > Testing on private branch post other changes pending, tested locally. > > > Thanks, > > Santhosh Edukulla > > --===============1877970865009693563==--