From dev-return-50286-apmail-cloudstack-dev-archive=cloudstack.apache.org@cloudstack.apache.org Thu Jan 16 19:01:49 2014 Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9123F10C86 for ; Thu, 16 Jan 2014 19:01:49 +0000 (UTC) Received: (qmail 59855 invoked by uid 500); 16 Jan 2014 19:01:48 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 59805 invoked by uid 500); 16 Jan 2014 19:01:48 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 59793 invoked by uid 99); 16 Jan 2014 19:01:48 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Jan 2014 19:01:48 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B5BDE1D43E4; Thu, 16 Jan 2014 19:01:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4016625769760454089==" MIME-Version: 1.0 Subject: Re: Review Request 16974: (ACS4.3) Juniper Contrail Plugin fixes From: "Hugo Trippaers" To: "Sachchidanand Vaidya" , "Hugo Trippaers" , "cloudstack" Date: Thu, 16 Jan 2014 19:01:47 -0000 Message-ID: <20140116190147.12830.5989@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Hugo Trippaers" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/16974/ X-Sender: "Hugo Trippaers" References: <20140116185323.24938.94104@reviews.apache.org> In-Reply-To: <20140116185323.24938.94104@reviews.apache.org> Reply-To: "Hugo Trippaers" X-ReviewRequest-Repository: cloudstack-git --===============4016625769760454089== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16974/#review32050 ----------------------------------------------------------- Are these fixes release blockers or can they go into 4.4? The release 4.3 is effectively closed by now. Cheers, Hugo - Hugo Trippaers On Jan. 16, 2014, 6:53 p.m., Sachchidanand Vaidya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16974/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2014, 6:53 p.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > ------- > > These are additional fixes to make Juniper Contrail plugin work in ACS4.3. > These changes were missed during last commit > > > Diffs > ----- > > plugins/network-elements/juniper-contrail/pom.xml 22167fe > plugins/network-elements/juniper-contrail/resources/META-INF/cloudstack/contrail/module.properties PRE-CREATION > plugins/network-elements/juniper-contrail/resources/META-INF/cloudstack/contrail/spring-contrail-context.xml PRE-CREATION > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java 18e8bde > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java 6587534 > plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java 82f2cc4 > plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/IntegrationTestConfiguration.java dec4a9e > plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java 195e932 > plugins/network-elements/juniper-contrail/test/resources/commonContext.xml c577513 > > Diff: https://reviews.apache.org/r/16974/diff/ > > > Testing > ------- > > Locally tested on centOS6.3 machine. > > > Thanks, > > Sachchidanand Vaidya > > --===============4016625769760454089==--