From dev-return-49429-apmail-cloudstack-dev-archive=cloudstack.apache.org@cloudstack.apache.org Fri Jan 3 05:50:37 2014 Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7E16F106C8 for ; Fri, 3 Jan 2014 05:50:37 +0000 (UTC) Received: (qmail 16847 invoked by uid 500); 3 Jan 2014 05:49:28 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 16744 invoked by uid 500); 3 Jan 2014 05:49:10 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 16555 invoked by uid 99); 3 Jan 2014 05:48:53 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Jan 2014 05:48:53 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9CDCD1D4125; Fri, 3 Jan 2014 05:48:51 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8657313450451472094==" MIME-Version: 1.0 Subject: Re: Review Request 16570: CLOUDSTACK-5185: Fixed test script related to cleanup in test_egress_fw_rules.py From: "Girish Shilamkar" To: "Girish Shilamkar" Cc: "Gaurav Aradhye" , "cloudstack" Date: Fri, 03 Jan 2014 05:48:51 -0000 Message-ID: <20140103054851.26158.57965@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Girish Shilamkar" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/16570/ X-Sender: "Girish Shilamkar" References: <20140102153644.29218.48917@reviews.apache.org> In-Reply-To: <20140102153644.29218.48917@reviews.apache.org> Reply-To: "Girish Shilamkar" X-ReviewRequest-Repository: cloudstack-git --===============8657313450451472094== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16570/#review31112 ----------------------------------------------------------- Ship it! Committed to 4.3 and master - Girish Shilamkar On Jan. 2, 2014, 3:36 p.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16570/ > ----------------------------------------------------------- > > (Updated Jan. 2, 2014, 3:36 p.m.) > > > Review request for cloudstack and Girish Shilamkar. > > > Bugs: CLOUDSTACK-5185 > https://issues.apache.org/jira/browse/CLOUDSTACK-5185 > > > Repository: cloudstack-git > > > Description > ------- > > Whenever VM deployment fails, cleanup fails with attribute error "virtual_machine not present". > Also, when VM is deployed in error state, it is expunged automatically and deleting that VM fails with "vm id not found". > > Fixed above issues. > > > Diffs > ----- > > test/integration/component/test_egress_fw_rules.py 87bf5df > > Diff: https://reviews.apache.org/r/16570/diff/ > > > Testing > ------- > > Tested locally. > > > Thanks, > > Gaurav Aradhye > > --===============8657313450451472094==--