cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chiradeep Vittal <Chiradeep.Vit...@citrix.com>
Subject Re: [DISCUSS][findbugs] proposing fixes or just do it
Date Thu, 30 Jan 2014 11:03:06 GMT
Just do it. Although, I suspect that piece of code may be generated from
the API WSDL

On 1/30/14 9:38 AM, "Daan Hoogland" <daan.hoogland@gmail.com> wrote:

>H Alex and others,
>
>I hesitate to ask you as it seems obvious, but in the awsapi project
>in com.cloud.bridge.model.SObjectItem.equals(Object other) a
>comparison is made
>            if 
>(!theObject.getId().equals(((SObjectItemVO)other).getTheObject()))
>which i think should be
>            if 
>(!theObject.getId().equals(((SObjectItemVO)other).getTheObject().getId()))
>The obvious question would be, 'am i correct?', or 'can i make the
>change?'.
>
>Now my real question is should I just go ahead and fix the scariest
>bugs that findbugs comes up with or should I consult with package
>maintainers for each part of the system on errors like these?
>
>(to comfort all of you, i restricted myself to doing this in master)
>
>regards,
>Daan


Mime
View raw message