cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hugo Trippaers <h...@trippaers.nl>
Subject Re: [VOTE] Apache CloudStack 4.3.0 (first round)
Date Thu, 23 Jan 2014 13:32:23 GMT
Thanks Abhi. I think that means that we need to consider this a mine and needs fixing. 

Unfortunately that means a -1 on the current RC, but i hope people will continue testing this
RC so we get some more feedback.




Cheers,

Hugo




On 23 jan. 2014, at 10:16, Abhinandan Prateek <Abhinandan.Prateek@citrix.com> wrote:

> Long values till at least 128 are cached, the ref being same, the ==
> operator is guaranteed to work for values from -127 to 128.
> It the value can go beyond that range then this is a potential mine.
> 
> -abhi
> 
> On 23/01/14 1:51 pm, "Hugo Trippaers" <hugo@trippaers.nl> wrote:
> 
>> Thanks Animesh,
>> 
>> Great to see the first RC for 4.3.
>> 
>> I¹ve been running some findbugs analysis on master and found several
>> issues that also seem to be present in the 4.3 branch. I¹ve made two
>> commit on master that fixed some issues that i spotted
>> (c2da2803476d55e814ec0d849482bd07c4f9f8f1 and
>> d19157fbb169eec029d1efee9ddd06e6b6aad9a4). Both fix an issue where an
>> object is compared by using == instead of equals. I¹m doubting if this is
>> worth to -1 the current RC as i can¹t oversee the impact of these bugs
>> and looking for opinions.
>> 
>> Cheers,
>> 
>> Hugo
>> 
>> 
>> 
>> 
>> 
>> 
>> On 23 jan. 2014, at 06:54, Animesh Chaturvedi
>> <animesh.chaturvedi@citrix.com> wrote:
>> 
>>> 
>>> 
>>> 
>>> Hi All,
>>> 
>>> 
>>> 
>>> I've created a 4.3.0 release, with the following artifacts up for a
>>> 
>>> vote:
>>> 
>>> 
>>> 
>>> Git Branch and Commit SH:
>>> 
>>> 
>>> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=ref
>>> s/heads/4.3
>>> Commit: 43d485c92d5919085cacb1cd0c7e78503ab9788a
>>> 
>>> 
>>> 
>>> List of changes:
>>> 
>>> 
>>> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blob_plain;f=C
>>> HANGES;hb=4.3
>>> 
>>> 
>>> 
>>> Source release (checksums and signatures are available at the same
>>> 
>>> location):
>>> 
>>> https://dist.apache.org/repos/dist/dev/cloudstack/4.3.0/
>>> 
>>> 
>>> 
>>> PGP release keys (signed using 94BE0D7C):
>>> 
>>> https://dist.apache.org/repos/dist/release/cloudstack/KEYS
>>> 
>>> 
>>> 
>>> Testing instructions are here:
>>> 
>>> 
>>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+test+proce
>>> dure
>>> 
>>> 
>>> 
>>> Vote will be open for 72 hours.
>>> 
>>> 
>>> 
>>> For sanity in tallying the vote, can PMC members please be sure to
>>> indicate "(binding)" with their vote?
>>> 
>>> 
>>> 
>>> [ ] +1  approve
>>> 
>>> [ ] +0  no opinion
>>> 
>>> [ ] -1  disapprove (and reason why)
>>> 
>>> 
>>> 
>> 
> 


Mime
View raw message