cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Suresh Balineni <sbalin...@service.juniper.net>
Subject Re: Review Request 16805: Contrail plugin fixes - db update, policy port end fix
Date Mon, 13 Jan 2014 21:20:13 GMT
Hi Sheng,

This is a reminder. Can you please ship this?

Thanks,
Suresh


On Jan 11, 2014, at 4:13 PM, "Suresh Balineni" <sbalineni@service.juniper.net<mailto:sbalineni@service.juniper.net>>
wrote:

Hi Sheng,

This is another 4.3 review request. Code changes are minimal.
Can you please review and the update the repository?

Thanks,
Suresh

From: Suresh Balineni <sbalineni@juniper.net<mailto:sbalineni@juniper.net>>
Reply-To: Suresh Balineni <sbalineni@service.juniper.net<mailto:sbalineni@service.juniper.net>>
Date: Saturday, January 11, 2014 4:08 PM
To: Suresh Balineni <sbalineni@service.juniper.net<mailto:sbalineni@service.juniper.net>>,
cloudstack <dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org>>
Subject: Review Request 16805: Contrail plugin fixes - db update, policy port end fix

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16805/

Review request for cloudstack.
By Suresh Balineni.
Repository: cloudstack-git
Description

Contrail plugin fixes.
- db updates must be done inside a transaction.
- network policy port end type error.
- default host contrail vnc is set to local host. This is considered if config is not present.


Testing

verified locally.


Diffs

  *   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java
(18e8bde)
  *   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java
(eea5026)
  *   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/NetworkPolicyModel.java
(d5a8722)

View Diff<https://reviews.apache.org/r/16805/diff/>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message