cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "prashant mishra" <prashantkumar.mis...@citrix.com>
Subject Re: Review Request 17391: Fix base.py for Dynamic compute offerings
Date Tue, 28 Jan 2014 12:46:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17391/
-----------------------------------------------------------

(Updated Jan. 28, 2014, 12:46 p.m.)


Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri.


Changes
-------

updated the base.py with suggested changes 


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-5951
    https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-5951


Repository: cloudstack-git


Description
-------

with dynamic computer offering feature  service offering can be created without cpunumber,cpuspeed
, memory and these values can be provided at time of vm deployment 

issue: cpuspeed,cpunumber,memory is compulsory to create SO and these values cant be passed
in deployVirtualMachine  API.
 
Fix: cpuspeed, cpunumber,memory will be optional  parameter, and these values can be passed
in  deployVirtualMachine API.


Diffs (updated)
-----

  tools/marvin/marvin/integration/lib/base.py 409530c 

Diff: https://reviews.apache.org/r/17391/diff/


Testing
-------

Tested vm deployment with regular computer offering and custom compute offerings


Thanks,

prashant mishra


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message