cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF Subversion and Git Services" <asf...@urd.zones.apache.org>
Subject Re: Review Request 16540: CLOUDSTACK-5692: cleanup API response for primary/secondary storages
Date Fri, 17 Jan 2014 08:19:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16540/#review32133
-----------------------------------------------------------


Commit 330571cea64006e2bab0a19528290cce699107e5 in branch refs/heads/4.3 from Saksham Srivastava
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=330571c ]

CLOUDSTACK-5692: obscure passwords when using cifs as storage


- ASF Subversion and Git Services


On Jan. 16, 2014, 1:52 p.m., Saksham Srivastava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16540/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2014, 1:52 p.m.)
> 
> 
> Review request for cloudstack and Devdeep Singh.
> 
> 
> Bugs: CLOUDSTACK-5692
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5692
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Cleanup the API response while listing primary/secondary stores while using cifs.
> Cleanup logs and remove passwords.
> 
> 
> Diffs
> -----
> 
>   core/src/com/cloud/agent/transport/Request.java cbeb112 
>   plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
1edfea3 
>   server/src/com/cloud/api/query/dao/ImageStoreJoinDaoImpl.java 8022871 
>   server/src/com/cloud/api/query/dao/StoragePoolJoinDaoImpl.java 4d2aac2 
> 
> Diff: https://reviews.apache.org/r/16540/diff/
> 
> 
> Testing
> -------
> 
> Tested locally.
> 
> The api response for list doesnot contain passwords:
> 
> "listimagestoresresponse" : { "count":1 ,"imagestore" : [  {"id":"182cfbfd-6343-4f35-804c-6b388fbf6a18","zoneid":"1ae705a4-c9bc-4977-9260-ce128d7fd3d8","zonename":"zone1","name":"secondary1","url":"cifs://10.102.192.151/SMB-Share/saksham/secondary?user=administrator&domain=blr","protocol":"cifs","providername":"NFS","scope":"ZONE","details":[]}
] } }
> 
> The logs also do not contain passwords :
> 
> 2014-01-16 18:48:53,288 DEBUG [o.a.c.f.j.i.AsyncJobManagerImpl] (Job-Executor-2:ctx-24ee5b9d
ctx-b4e28b06) Complete async job-62, jobStatus: SUCCEEDED, resultCode: 0, result: org.apache.cloudstack.api.response.StoragePoolResponse/storagepool/{"id":"c59cc1c9-8d16-3090-95e7-d5c54839cf2c","zoneid":"1ae705a4-c9bc-4977-9260-ce128d7fd3d8","zonename":"zone1","podid":"bd328cfc-692e-4c8c-8d32-e2a34abaaa37","podname":"pod1","name":"primary1","ipaddress":"10.102.192.150","path":"/SMB-Share/saksham/primary?user\u003dadministrator\u0026domain\u003dblr","created":"2014-01-07T16:28:35+0530","type":"NetworkFilesystem","clusterid":"fc1df888-0e90-45c2-8555-5d4ed61c7bc3","clustername":"cluster1","disksizetotal":500105736192,"disksizeallocated":0,"tags":"sggss","state":"Up","scope":"CLUSTER","jobid":"dfbd2072-48dc-457d-a417-312a74c517f9","jobstatus":0}
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message