cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Murali Reddy" <muralimmre...@gmail.com>
Subject Re: Review Request 16249: CLOUDSTACK-5496 : Account included in ActionEvents is Project Account ID
Date Fri, 17 Jan 2014 06:06:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16249/#review32129
-----------------------------------------------------------


changes look good, patch does not apply on master. Can you please resubmit.

Also please see if the patch applies on 4.2, when you resubmit. 

- Murali Reddy


On Dec. 31, 2013, 2:45 p.m., David Grizzanti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16249/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2013, 2:45 p.m.)
> 
> 
> Review request for cloudstack and Murali Reddy.
> 
> 
> Bugs: CLOUDSTACK-5496
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5496
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-5496 : Account included in ActionEvents is Project Account ID
> 
> When Action Events are generated and placed on the Event Bus, an "account" parameter
is included with the event. When these events are generated for resources within projects,
this "account" parameter is not useful as it's the UUID of the project account, instead of
the project. 
> 
> To solve this, I updated ActionEventsUtil class to include a "project" parameter in the
generated events when the resource is being changed/add/deleted in a project.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/event/ActionEventUtils.java 5956eae 
>   server/test/org/apache/cloudstack/affinity/AffinityApiUnitTest.java 7e21c09 
> 
> Diff: https://reviews.apache.org/r/16249/diff/
> 
> 
> Testing
> -------
> 
> Testing done 4.2
> 
> 
> Thanks,
> 
> David Grizzanti
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message