cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sheng Yang" <sh...@yasker.org>
Subject Re: Review Request 16258: Add new physical network isolationMethod (L3VPN) for Juniper Contrail plugin.
Date Tue, 14 Jan 2014 21:25:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16258/#review31802
-----------------------------------------------------------


Looks good to me, but cannot applied to the latest MASTER branch(I suppose that's the target).

- Sheng Yang


On Jan. 13, 2014, 5:46 a.m., Sachchidanand Vaidya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16258/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2014, 5:46 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Add new physical network isolationMethod (L3VPN) for Juniper Contrail network Plugin.
ContrailGuru checks for IsolationMethod before designing a VN. 
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/network/PhysicalNetwork.java cfa236d 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java
ea52be9 
>   plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java
c449b8a 
>   ui/scripts/ui-custom/zoneWizard.js 28df193 
> 
> Diff: https://reviews.apache.org/r/16258/diff/
> 
> 
> Testing
> -------
> 
> Changes pass unit tests and complete centos63 package build.
> 
> 
> Thanks,
> 
> Sachchidanand Vaidya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message