cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Balineni" <sbalin...@juniper.net>
Subject Re: Review Request 16642: Contrail plguin fixes for CS 4.3
Date Sat, 11 Jan 2014 00:50:08 GMT


> On Jan. 11, 2014, 12:03 a.m., Sheng Yang wrote:
> > Ship It!
> 
> Sheng Yang wrote:
>     Applied to 4.3 branch. Thanks.
>     
>     But need a patch for master branch as well.
> 
> Sheng Yang wrote:
>     Reverted from 4.3 branch.
>     
>     It cannot compile.

Hi Sheng,

I submitted revision 2 version which has resolved compilation errors. But for some reason,
it does not show my latest patch. Review tool is always always the first diff.

Let me know what is the best way to submit my patch.

- Suresh


- Suresh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16642/#review31556
-----------------------------------------------------------


On Jan. 11, 2014, 12:44 a.m., Suresh Balineni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16642/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2014, 12:44 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> - Contrail plugin bug fixes for CS 4.3.
> - Code cleanup.
> - Most of the fixes are in plugin code.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/network/Network.java 0d916ab 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java
dfbe7d3 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java
ca53f41 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManager.java
b96b00c 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java
4eaafca 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java
f705f07 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java
7a77040 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerEventHandlerImpl.java
ec37440 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java
47fc99e 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/NetworkPolicyModel.java
PRE-CREATION 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java
20b80be 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java
ec20a94 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java
b4968ac 
>   plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java
86750ca 
>   plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/NetworkProviderTest.java
40cd1ea 
> 
> Diff: https://reviews.apache.org/r/16642/diff/
> 
> 
> Testing
> -------
> 
> verified locally.
> 
> 
> Thanks,
> 
> Suresh Balineni
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message