cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alena Prokharchyk" <alena.prokharc...@citrix.com>
Subject Re: Review Request 16750: CLOUDSTACK-5651 deployVm: customparameters param name has to be changed
Date Thu, 09 Jan 2014 22:03:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16750/#review31467
-----------------------------------------------------------


One minor suggestion - can you please change this place:

private  Map Details;

so "Details" start with lowercase d? Thats the java convention that instance/local vars and
function names should be camelcased. 

- Alena Prokharchyk


On Jan. 9, 2014, 12:29 p.m., bharat kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16750/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2014, 12:29 p.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
>  CLOUDSTACK-5651 deployVm: customparameters param name has to be changed
>  https://issues.apache.org/jira/browse/CLOUDSTACK-5651
> 
> 
> Diffs
> -----
> 
>   api/src/org/apache/cloudstack/api/ApiConstants.java fbd3df8 
>   api/src/org/apache/cloudstack/api/command/admin/systemvm/ScaleSystemVMCmd.java 2020622

>   api/src/org/apache/cloudstack/api/command/admin/systemvm/UpgradeSystemVMCmd.java 531cddc

>   api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java a8a21ab 
>   api/src/org/apache/cloudstack/api/command/user/vm/ScaleVMCmd.java 1716b61 
>   api/src/org/apache/cloudstack/api/command/user/vm/UpgradeVMCmd.java 140931e 
>   server/src/com/cloud/server/ManagementServerImpl.java d81e847 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 23df880 
> 
> Diff: https://reviews.apache.org/r/16750/diff/
> 
> 
> Testing
> -------
> 
> Tested on 4.3
> 
> 
> Thanks,
> 
> bharat kumar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message