cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcus Sorensen" <shadow...@gmail.com>
Subject Re: Review Request 16361: CLOUDSTACK-5535: Do not allow addNetwork to create NIC across VPC tiers and Isolated Networks
Date Thu, 09 Jan 2014 19:03:01 GMT


> On Jan. 9, 2014, 6:22 p.m., Alena Prokharchyk wrote:
> > Saksham,
> > 
> > The patch fails on 4.3 branch with the error:
> > 
> > Applying: CLOUDSTACK-5535 : Do not allow addNetwork to create NIC across VPC tiers
and Isolated Networks
> > error: patch failed: server/src/com/cloud/vm/UserVmManagerImpl.java:973
> > error: server/src/com/cloud/vm/UserVmManagerImpl.java: patch does not apply
> > Patch failed at 0001 CLOUDSTACK-5535 : Do not allow addNetwork to create NIC across
VPC tiers and Isolated Networks
> > The copy of the patch that failed is found in:
> >    /Users/alena/repos/dr/cloudstack/.git/rebase-apply/patch
> > 
> > 
> > Please fix and submit again. Also submit a separate patch for the master branch,
as there are changes in code style that might affect the cherry-pick.

Please dont submit again! :-) See my comments on CLOUDSTACK-5535


- Marcus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16361/#review31444
-----------------------------------------------------------


On Dec. 19, 2013, 5:25 a.m., Saksham Srivastava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16361/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2013, 5:25 a.m.)
> 
> 
> Review request for cloudstack and Alena Prokharchyk.
> 
> 
> Bugs: CLOUDSTACK-5535
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5535
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> addNetworkToVM allows adding any network to VM.
> Ideally a VM running in isolated Guest Network should not be able to add a VPC tier.
> A VM running in VPC tier should not be allowed to add another tier
> A VM running in VPC tier should not be allowed to add another isolated guest network
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 3ad49d8 
> 
> Diff: https://reviews.apache.org/r/16361/diff/
> 
> 
> Testing
> -------
> 
> VM having a nic in isolated guest network cannot add a VPC tier.
> VM having a nic in one VPC tier cannot add another VPC tier.
> VM having a nic in a VPC tier cannot add a isolated guest network.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message