cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF Subversion and Git Services" <asf...@urd.zones.apache.org>
Subject Re: Review Request 16731: CLOUDSTACK-5803: Fixed issues related to egress rule
Date Wed, 08 Jan 2014 12:28:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16731/#review31363
-----------------------------------------------------------


Commit 777ab1494205667c073f3d876d2ba1665b5c3f4b in branch refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=777ab14 ]

CLOUDSTACK-5803: Fixed issues related to egress rule


- ASF Subversion and Git Services


On Jan. 8, 2014, 8:20 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16731/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2014, 8:20 a.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-5191 and CLOUDSTACK-5803
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5191
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5803
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Changes:
> 
> 1) Ping to outside world was failing because the egress rule was created for TCP protocol.
> Changed it to ICMP.
> 
> 2) Changed assertion for security group behavior after revoking egress rule. By default,
all outbound traffic is allowed when there is no egress rule is defined. This also fixes CLOUDSTACK-5191.
> 
> 3) Code cleanup - removing unused variables, modification of imports.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_egress_rules.py 590f72a 
> 
> Diff: https://reviews.apache.org/r/16731/diff/
> 
> 
> Testing
> -------
> 
> Tested on basic setup with SG.
> 
> Log:
> 
> test_authorizeIngressRule (test_egress_rules.TestAuthorizeIngressRule)
> Test authorize ingress rule ... skipped 'skip'
> test_01_default_group_with_egress (test_egress_rules.TestDefaultGroupEgress)
> Test default group with egress rule before VM deploy and ping, ssh ... ok
> test_01_default_group_with_egress (test_egress_rules.TestDefaultGroupEgressAfterDeploy)
> Test default group with egress rule added after vm deploy and ping, ... ok
> test_deployVM_InDefaultSecurityGroup (test_egress_rules.TestDefaultSecurityGroupEgress)
> Test deploy VM in default security group with no egress rules ... skipped 'skip'
> test_invalid_account_authroize (test_egress_rules.TestInvalidAccountAuthroize)
> Test invalid account authroize ... skipped 'skip'
> test_invalid_parameters (test_egress_rules.TestInvalidParametersForEgress)
> Test invalid parameters for egress rules ... skipped 'skip'
> test_multiple_account_egress_rule_positive (test_egress_rules.TestMultipleAccountsEgressRule)
> Test multiple account egress rules positive case ... skipped 'skip'
> test_multiple_account_egress_rule_negative (test_egress_rules.TestMultipleAccountsEgressRuleNeg)
> Test multiple account egress rules negative case ... skipped 'skip'
> test_revoke_egress_rule (test_egress_rules.TestRevokeEgressRule)
> Test revoke security group egress rule ... ok
> test_start_stop_vm_egress (test_egress_rules.TestStartStopVMWithEgressRule)
> Test stop start Vm with egress rules ... skipped 'skip'
> 
> ----------------------------------------------------------------------
> Ran 10 tests in 361.398s
> 
> OK (skipped=7)
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message