cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Saksham Srivastava" <>
Subject Re: Review Request 14124: CLOUDSTACK-4622 : If a VM from guest network is added to network tier of VPC then IP reservation allows the CIDR to be a superset of Network CIDR for that VPC tier
Date Tue, 07 Jan 2014 11:58:32 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 7, 2014, 11:58 a.m.)

Review request for cloudstack, Jayapal Reddy and Sateesh Chodapuneedi.


Updating patch, resolving conflicts and adding more unit-tests.


Repository: cloudstack-git


Add a new utility method for comparing 2 CIDRs.
The method takes in 2 cidrs, cidrA and cidrB and returns true if cidrA's IP range is equal
or a subset of cidrB's IP range.

Diffs (updated)

  utils/src/com/cloud/utils/net/ 266a5d1 
  utils/test/com/cloud/utils/net/ b049516 



Added unit test for the utility.
Tested locally.
Build is successful.
Patch applies cleanly.


Saksham Srivastava

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message