Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 155CB10F06 for ; Tue, 31 Dec 2013 02:35:25 +0000 (UTC) Received: (qmail 71581 invoked by uid 500); 31 Dec 2013 02:35:24 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 71547 invoked by uid 500); 31 Dec 2013 02:35:24 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 71536 invoked by uid 99); 31 Dec 2013 02:35:24 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 Dec 2013 02:35:24 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 453FC1D410E; Tue, 31 Dec 2013 02:35:22 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6528581905772639574==" MIME-Version: 1.0 Subject: Re: Review Request 11981: Adding base support for NVP security groups to the NVP API From: "Amogh Vasekar" To: "Hugo Trippaers" Cc: "Amogh Vasekar" , "Adrian Steer" , "cloudstack" Date: Tue, 31 Dec 2013 02:35:22 -0000 Message-ID: <20131231023522.21784.61676@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Amogh Vasekar" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/11981/ X-Sender: "Amogh Vasekar" References: <20130619212855.32008.81792@reviews.apache.org> In-Reply-To: <20130619212855.32008.81792@reviews.apache.org> Reply-To: "Amogh Vasekar" X-ReviewRequest-Repository: cloudstack-git --===============6528581905772639574== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11981/#review30992 ----------------------------------------------------------- Reminder - Hi, This request has been pending for long. Please take the time to address the comments raised. Thanks! - Amogh Vasekar On June 19, 2013, 9:28 p.m., Adrian Steer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11981/ > ----------------------------------------------------------- > > (Updated June 19, 2013, 9:28 p.m.) > > > Review request for cloudstack and Hugo Trippaers. > > > Repository: cloudstack-git > > > Description > ------- > > This is initial version of API implementation of security groups within the NVP API > > > Diffs > ----- > > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/LogicalSwitchPort.java c571458 > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraAddressPairs.java PRE-CREATION > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraLogicalPortRule.java PRE-CREATION > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java 12fa6c0 > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraSecurityProfile.java PRE-CREATION > > Diff: https://reviews.apache.org/r/11981/diff/ > > > Testing > ------- > > Compile testing > > > Thanks, > > Adrian Steer > > --===============6528581905772639574==--