Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============8258433120332414140=="
MIME-Version: 1.0
Subject: Re: Review Request 16513: CLOUDSTACK-5635: Fixed issue (Max volumes
 has been
 exceeded for domain during test) in test_resource_limits.py
From: "Girish Shilamkar" <girish@clogeny.com>
To: "Girish Shilamkar" <girish@clogeny.com>
Cc: "Gaurav Aradhye" <gaurav.aradhye@clogeny.com>,
 "cloudstack" <dev@cloudstack.apache.org>
Date: Mon, 30 Dec 2013 12:38:35 -0000
Message-ID: <20131230123835.21727.37112@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Girish Shilamkar" <noreply@reviews.apache.org>
References: <20131230122349.21727.14383@reviews.apache.org>
In-Reply-To: <20131230122349.21727.14383@reviews.apache.org>
Reply-To: "Girish Shilamkar" <girish@clogeny.com>

--===============8258433120332414140==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16513/#review30961
-----------------------------------------------------------


Committed to 4.3 and master

- Girish Shilamkar


On Dec. 30, 2013, 12:23 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16513/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2013, 12:23 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-5635
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5635
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Added wait after the cleanup operations so that the all the VMs are expunged before execution of the next test case.
> In case VMs are not expunged, their volumes will be counted in the volume count of the account/domain, which is not desired.
> 
> Also, did code cleanup, removing unused variables, and modifying imports.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_resource_limits.py 07fc5a5 
> 
> Diff: https://reviews.apache.org/r/16513/diff/
> 
> 
> Testing
> -------
> 
> Tested locally on XenServer advanced setup.
> 
> Log:
> test_maxAccountNetworks (test_resource_limits.TestMaxAccountNetworks)
> Test Limit number of guest account specific networks ... skipped 'skip'
> test_01_vm_per_account (test_resource_limits.TestResourceLimitsAccount)
> Test VM limit per account ... skipped 'skip'
> test_02_publicip_per_account (test_resource_limits.TestResourceLimitsAccount)
> Test Public IP limit per account ... skipped 'skip'
> test_03_snapshots_per_account (test_resource_limits.TestResourceLimitsAccount)
> Test Snapshot limit per account ... skipped 'skip'
> test_04_volumes_per_account (test_resource_limits.TestResourceLimitsAccount)
> Test Volumes limit per account ... skipped 'skip'
> test_05_templates_per_account (test_resource_limits.TestResourceLimitsAccount)
> Test Templates limit per account ... skipped 'skip'
> test_01_publicip_per_domain (test_resource_limits.TestResourceLimitsDomain)
> Test Public IP limit per domain ... skipped 'skip'
> test_01_vm_per_domain (test_resource_limits.TestResourceLimitsDomain)
> Test VM limit per domain ... ok
> test_03_snapshots_per_domain (test_resource_limits.TestResourceLimitsDomain)
> Test Snapshot limit per domain ... ok
> test_04_volumes_per_domain (test_resource_limits.TestResourceLimitsDomain)
> Test Volumes limit per domain ... ok
> test_05_templates_per_domain (test_resource_limits.TestResourceLimitsDomain)
> Test Templates limit per domain ... ok
> 
> ----------------------------------------------------------------------
> Ran 11 tests in 819.812s
> 
> OK (skipped=7)
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


--===============8258433120332414140==--