Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============9107118077182751738=="
MIME-Version: 1.0
Subject: Re: Review Request 16324: CLOUDSTACK-4780: Changes related to
 checking
 snapshot on NFS server
From: "ASF Subversion and Git Services" <asfbot@urd.zones.apache.org>
To: "Girish Shilamkar" <girish@clogeny.com>,
 "SrikanteswaraRao Talluri" <srikanteswararao.talluri@citrix.com>
Cc: "Gaurav Aradhye" <gaurav.aradhye@clogeny.com>,
 "ASF Subversion and Git Services" <asfbot@urd.zones.apache.org>,
 "cloudstack" <dev@cloudstack.apache.org>
Date: Sat, 21 Dec 2013 07:18:05 -0000
Message-ID: <20131221071805.963.26164@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "ASF Subversion and Git Services" <noreply@reviews.apache.org>
References: <20131217152123.30006.21239@reviews.apache.org>
In-Reply-To: <20131217152123.30006.21239@reviews.apache.org>
Reply-To: "ASF Subversion and Git Services" <asfbot@urd.zones.apache.org>

--===============9107118077182751738==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16324/#review30778
-----------------------------------------------------------


Commit fde14bcc326b377b24b7f310793a6e0a4271e95a in branch refs/heads/master from Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=fde14bc ]

Revert "CLOUDSTACK-4780: Changes related to checking snapshot on NFS server"

This reverts commit 33fb241fdf7f363659db918b8f6dd5744f599259.


- ASF Subversion and Git Services


On Dec. 17, 2013, 3:21 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16324/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2013, 3:21 p.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-4780
>     https://issues.apache.org/jira/browse/CLOUDSTACK-4780
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Changes:
> 
> 1) Appended snapshot extension to the snapshot path coming from database. As discussed with Harikrishna, Product bug (5135) is invalid, snapshot path in database won't contain the extension of the snapshot. So changing the code so as to append the extension based on hypervisor type.
> 
> 2) Code movement and cleanup - Moved function get_hypervisor_type from common to utils to avoid cyclic dependency of libraries. Also, cleaned up the imports.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_add_remove_network.py f1508e1 
>   test/integration/component/test_snapshots.py d3fac42 
>   tools/marvin/marvin/integration/lib/common.py 096b073 
>   tools/marvin/marvin/integration/lib/utils.py d046235 
> 
> Diff: https://reviews.apache.org/r/16324/diff/
> 
> 
> Testing
> -------
> 
> Tested locally on VMware. KVM should not have impact of this change as the snapshot created on KVM was found not to have any extension.
> 
> Log:
> test_01_snapshot_root_disk (test_snapshots.TestSnapshotRootDisk)
> Test Snapshot Root Disk ... ok
> 
> ----------------------------------------------------------------------
> Ran 1 test in 513.783s
> 
> OK
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


--===============9107118077182751738==--