Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============1474011268596304293=="
MIME-Version: 1.0
Subject: Re: Review Request 16362: CLOUDSTACK-5554: Custom disk offering
 allows to
 create a datadisk with size greater than custom.diskoffering.size.max value
From: "ASF Subversion and Git Services" <asfbot@urd.zones.apache.org>
To: "Kishan Kavala" <Kishan.Kavala@citrix.com>
Cc: "ASF Subversion and Git Services" <asfbot@urd.zones.apache.org>,
 "Harikrishna Patnala" <harikrishna.patnala@citrix.com>,
 "cloudstack" <dev@cloudstack.apache.org>
Date: Thu, 19 Dec 2013 10:55:30 -0000
Message-ID: <20131219105530.2160.61546@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "ASF Subversion and Git Services" <noreply@reviews.apache.org>
References: <20131219102756.2160.348@reviews.apache.org>
In-Reply-To: <20131219102756.2160.348@reviews.apache.org>
Reply-To: "ASF Subversion and Git Services" <asfbot@urd.zones.apache.org>

--===============1474011268596304293==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16362/#review30688
-----------------------------------------------------------


Commit 707da55fe3f94e95ee0186fd119f78d1d3def5c7 in branch refs/heads/master from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=707da55 ]

CLOUDSTACK-5554: Custom disk offering allows to create a datadisk with size greater than custom.diskoffering.size.max value Fixed both custom.diskoffering.size.max and custom.diskoffering.size.min to ensure input values while deploying the VM and creating volume APIs.

Moved both parameters to VolumeOrchestrationService using ConfigDepot


- ASF Subversion and Git Services


On Dec. 19, 2013, 10:27 a.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16362/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2013, 10:27 a.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Bugs: CLOUDSTACK-5554
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5554
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-5554: Custom disk offering allows to create a datadisk with size greater than custom.diskoffering.size.max value 
> Fixed both custom.diskoffering.size.max and custom.diskoffering.size.min to ensure input values while deploying the VM and creating volume APIs.
> 
> Moved both parameters to VolumeOrchestrationService using ConfigDepot
> 
> 
> Diffs
> -----
> 
>   engine/api/src/org/apache/cloudstack/engine/orchestration/service/VolumeOrchestrationService.java a9ccc06 
>   engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java efaa288 
>   server/src/com/cloud/configuration/Config.java 3893c2f 
>   server/src/com/cloud/server/ManagementServerImpl.java 8bc095d 
>   server/src/com/cloud/storage/VolumeApiServiceImpl.java 2fa023e 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 3ad49d8 
>   setup/db/db/schema-421to430.sql ba19ae6 
> 
> Diff: https://reviews.apache.org/r/16362/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


--===============1474011268596304293==--