Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AAD8E104AA for ; Tue, 17 Dec 2013 10:25:35 +0000 (UTC) Received: (qmail 31591 invoked by uid 500); 17 Dec 2013 10:25:33 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 31564 invoked by uid 500); 17 Dec 2013 10:25:29 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 31542 invoked by uid 99); 17 Dec 2013 10:25:26 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Dec 2013 10:25:26 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 483BF1C0133; Tue, 17 Dec 2013 10:25:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2278884401339177526==" MIME-Version: 1.0 Subject: Re: Review Request 16315: CLOUDSTACK-5495 Unable to stop VM From: "bharat kumar" To: "Koushik Das" Cc: "bharat kumar" , "cloudstack" Date: Tue, 17 Dec 2013 10:25:25 -0000 Message-ID: <20131217102525.30006.58193@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "bharat kumar" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/16315/ X-Sender: "bharat kumar" References: <20131217093855.27244.55703@reviews.apache.org> In-Reply-To: <20131217093855.27244.55703@reviews.apache.org> Reply-To: "bharat kumar" X-ReviewRequest-Repository: cloudstack-git --===============2278884401339177526== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16315/ ----------------------------------------------------------- (Updated Dec. 17, 2013, 10:25 a.m.) Review request for cloudstack and Koushik Das. Changes ------- removed the execute.in.sequence.hypervisor.commands from config.java Bugs: CLOUDSTACK-5495 https://issues.apache.org/jira/browse/CLOUDSTACK-5495 Repository: cloudstack-git Description ------- CLOUDSTACK-5495 Unable to stop VM This patch makes the execute.in.sequence.hypervisor.commands configurable for stopvm command. Diffs (updated) ----- engine/api/src/com/cloud/vm/VirtualMachineManager.java f9bb935 engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java bc6a32f server/src/com/cloud/configuration/Config.java b994ce3 server/src/com/cloud/server/ManagementServer.java f60ce48 server/src/com/cloud/server/ManagementServerImpl.java 0e9c483 Diff: https://reviews.apache.org/r/16315/diff/ Testing ------- Tested on 4.3 Thanks, bharat kumar --===============2278884401339177526==--