Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4AB7C101D9 for ; Wed, 4 Dec 2013 14:07:12 +0000 (UTC) Received: (qmail 43762 invoked by uid 500); 4 Dec 2013 14:07:09 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 43705 invoked by uid 500); 4 Dec 2013 14:07:07 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 43686 invoked by uid 99); 4 Dec 2013 14:07:04 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Dec 2013 14:07:04 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D8BA01D3C80; Wed, 4 Dec 2013 14:06:59 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7931554551311233081==" MIME-Version: 1.0 Subject: Re: Review Request 15875: https://issues.apache.org/jira/browse/CLOUDSTACK-5160 From: "daan Hoogland" To: "Koushik Das" , "Jayapal Reddy" Cc: "daan Hoogland" , "bharat kumar" , "cloudstack" Date: Wed, 04 Dec 2013 14:06:59 -0000 Message-ID: <20131204140659.25728.34003@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "daan Hoogland" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/15875/ X-Sender: "daan Hoogland" References: <20131203105305.12251.33828@reviews.apache.org> In-Reply-To: <20131203105305.12251.33828@reviews.apache.org> Reply-To: "daan Hoogland" X-ReviewRequest-Repository: cloudstack-git --===============7931554551311233081== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15875/#review29732 ----------------------------------------------------------- Bharat, neither version 4 nor version 3 of your patch apply to master. Also I noted the ticket number in the commit comment changed from 5160 to 5161. Can you explain. - daan Hoogland On Dec. 3, 2013, 10:53 a.m., bharat kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15875/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2013, 10:53 a.m.) > > > Review request for cloudstack, Jayapal Reddy and Koushik Das. > > > Bugs: CLOUDSTACK-5160 > https://issues.apache.org/jira/browse/CLOUDSTACK-5160 > > > Repository: cloudstack-git > > > Description > ------- > > use a map to specify the custom parameters in the deployvm api Instead of one parameter for each. > > https://issues.apache.org/jira/browse/CLOUDSTACK-5160 > > > Diffs > ----- > > api/src/com/cloud/vm/UserVmService.java 6fc8b54 > api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 3643f91 > engine/api/src/org/apache/cloudstack/engine/orchestration/service/VolumeOrchestrationService.java ad957d5 > engine/api/src/org/apache/cloudstack/engine/service/api/OrchestrationService.java 8c58227 > engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 4e25493 > engine/orchestration/src/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java 5dd15ce > engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java 71e8b7d > server/src/com/cloud/vm/UserVmManagerImpl.java a16f51c > > Diff: https://reviews.apache.org/r/15875/diff/ > > > Testing > ------- > > Tested on master. > > > Thanks, > > bharat kumar > > --===============7931554551311233081==--