Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9D3F110444 for ; Wed, 4 Dec 2013 06:03:58 +0000 (UTC) Received: (qmail 64083 invoked by uid 500); 4 Dec 2013 06:03:54 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 63986 invoked by uid 500); 4 Dec 2013 06:03:53 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 63940 invoked by uid 99); 4 Dec 2013 06:03:52 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Dec 2013 06:03:52 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 973C61D3CD4; Wed, 4 Dec 2013 06:03:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5813977488860227154==" MIME-Version: 1.0 Subject: Re: Review Request 15963: CLOUDSTACK-5347: Resolved issue related to snapshot state From: "ASF Subversion and Git Services" To: "Girish Shilamkar" , "SrikanteswaraRao Talluri" Cc: "Gaurav Aradhye" , "ASF Subversion and Git Services" , "cloudstack" Date: Wed, 04 Dec 2013 06:03:47 -0000 Message-ID: <20131204060347.25728.84549@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "ASF Subversion and Git Services" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/15963/ X-Sender: "ASF Subversion and Git Services" References: <20131203143200.12482.91536@reviews.apache.org> In-Reply-To: <20131203143200.12482.91536@reviews.apache.org> Reply-To: "ASF Subversion and Git Services" X-ReviewRequest-Repository: cloudstack-git --===============5813977488860227154== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15963/#review29715 ----------------------------------------------------------- Commit 454912d7b2d36f4578d3355798c737f5adba827c in branch refs/heads/4.2 from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=454912d ] CLOUDSTACK-5347: Resolved issue related to snapshot state - ASF Subversion and Git Services On Dec. 3, 2013, 2:31 p.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15963/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2013, 2:31 p.m.) > > > Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-5347 > https://issues.apache.org/jira/browse/CLOUDSTACK-5347 > > > Repository: cloudstack-git > > > Description > ------- > > The test case component.test_project_resources.TestSnapshots.test_06_create_snapshots_in_project failed due to "Check Snapshot state is Running or not" > > It was checking the snapshot state only in (CreatedOnPrimary, BackedUp). The snapshot could also be in "Allocated" state. > Snapshot is always first in allocated state, then createdOnPrimary and finally BackedUp. > > included "Allocated" state in the list. > > > Diffs > ----- > > test/integration/component/test_project_resources.py 9b9b2e6 > > Diff: https://reviews.apache.org/r/15963/diff/ > > > Testing > ------- > > Tested locally in XenServer advanced setup. > > > Thanks, > > Gaurav Aradhye > > --===============5813977488860227154==--